FAIRmat-NFDI / AreaA-data_modeling_and_schemas

The ELN custom schemas from synthesis experiments
https://fairmat-nfdi.github.io/AreaA-Documentation/
11 stars 6 forks source link

IKZ Hall schema #16

Open budschi opened 1 year ago

budschi commented 1 year ago

@domna and @aalbino2 please add the necessary tasks that need to be completed to finalize the Hall schema

aalbino2 commented 1 year ago
aalbino2 commented 1 year ago
aalbino2 commented 1 year ago
aalbino2 commented 1 year ago
aalbino2 commented 1 year ago
domna commented 1 year ago

This is a general problem. Python does not allow variable names to start with a number. So you probably need to rename this quantity.

  • [ ] there is a problem with quantities starting with numbers
2_sample_labeling = Quantity(
   type=str,
   description='Sample labeling in case of multiple samples, either 1A and 2A or 1A and 1B. Only applicable for certain Systems.')

So far, I just deleted the quantity from measurement_state_machine section

aalbino2 commented 1 year ago

yes, we maybe can insert in the reader some feature that translate number to literals. So the data_template generated is already okay and the nomad class can already contain a literal in the quantity name.

Let's see if other issues will emerge from this state of things.

This is a general problem. Python does not allow variable names to start with a number. So you probably need to rename this quantity.

  • [ ] there is a problem with quantities starting with numbers
2_sample_labeling = Quantity(
   type=str,
   description='Sample labeling in case of multiple samples, either 1A and 2A or 1A and 1B. Only applicable for certain Systems.')

So far, I just deleted the quantity from measurement_state_machine section

aalbino2 commented 1 year ago

I find some unexpected inconsistency in the instrument file, but this is out of our control: Reading Rate is not always the same string across the file

[Keithley 2000]
Reading Rate=1

[Keithley 2182]
Reading_Rate=0
aalbino2 commented 1 year ago
aalbino2 commented 1 year ago

A necessary step to arrive to the figures of merit of this experiment that will be shared with other colleagues.

This will allow to have the processing exposed together to the archive files in the upload. We need to get the Matlab code currently used and to translate it into a Jupyter notebook

aalbino2 commented 1 year ago

other questions:

budschi commented 1 year ago

ok, I looked into the Hall schema. I was wondering if the instrumnt part is connect to to the Hall measurement activitiy. If so, should it not be inside that section then? And the contact grafting is independent on the instrument part, is it?

budschi commented 1 year ago

we could also think of which is the data/information that should be easiliy accesible/displayed for other users like Ta-Shun who probably just want a number for doping, mobilty etc and a curve

anfiedler commented 1 year ago

In our set-up actually only [Temperature Controller] and [Temperature Controller - Loop 1] are important to understand how the temperature dependent hall effect measurement was performed. Even though [Platform System] and [Lake Shore 370] doesn't play a role in our set-up, I can not exclude this for other groups/users of a Lake Shore Hall measurement set-up. It depends on the set-up and I am not quite sure which one involves it. Hence, I would save just every value from the config file so nothing gets lost. Since it is just a couple numbers, it should be less than 1kB.

anfiedler commented 1 year ago

other questions:

* About the electrometer: the description says "If there is a control electrometer installed, which one is it? 0=[Keithley 6512] 1=[Keithley 6514]')" but in the instrument file we do not get any of them because they are not printed. Can you manage to make also the electrometer being printed in the instrument file?

* About the currentmeter: you told that `0: Keithley 6485, 1: Keithley 485/6/7`. In the file I find `CurrentMeter=1` but no  Keithley 485/6/7 is present in the file,  Keithley 6485 is present instead. Are you sure that these numbers are correct? If yes, why is it not showing in the file? could you manage to have it shown?

About electrometer and currentmeter. In both cases those devices are hard coded in the measurement program of Lake Shore. There is nothing that a user can change in those devices. Hence, it is only important to save, that they are part of the set-up to not lose the information.

anfiedler commented 1 year ago

@domna and @aalbino2 please add the necessary tasks that need to be completed to finalize the Hall schema

Intense testing phase will start in 2 weeks after training all users and make uploading mandatory

aalbino2 commented 1 year ago

we could also think of which is the data/information that should be easiliy accesible/displayed for other users like Ta-Shun who probably just want a number for doping, mobilty etc and a curve

we need mobility, resistivity, and doping concentration

aalbino2 commented 1 year ago

In our set-up actually only [Temperature Controller] and [Temperature Controller - Loop 1] are important to understand how the temperature dependent hall effect measurement was performed. Even though [Platform System] and [Lake Shore 370] doesn't play a role in our set-up, I can not exclude this for other groups/users of a Lake Shore Hall measurement set-up. It depends on the set-up and I am not quite sure which one involves it. Hence, I would save just every value from the config file so nothing gets lost. Since it is just a couple numbers, it should be less than 1kB.

I will add all the parameters in the sections [Temperature Controller] [Temperature Controller - Loop 1] [Platform System] [Lake Shore 370]. We will need a check of the units, the description, and the possible presence of lists of arguments of enumeration quantities (as already done before) @anfiedler I will send you an email with the file o doublecheck

aalbino2 commented 1 year ago

The Hall measurement schema and parser is now updated in the new plugin fashion showed during our last tutorial https://youtu.be/_5hADA1QVw8

The plugin can be cloned from here: https://github.com/aalbino2/IKZ-nomad-schema-plugin-example/tree/main/hall_IKZ

From now on, our effort on this example will be limited due to reorganization of our man power.

Further developments will be put here upon request

@budschi @anfiedler @MartinAlbrechtIKZ

aalbino2 commented 1 year ago

The import of nomad-parser-nexus that was present in the parser is now removed. The reason is that only a minor feature of nomad-parser-nexus was used, that is the "parse_txt" function and this was not justifying the maintenance effort necessary to keep the NeXus package import to work in this plugin.

This will not close the doors in the future to plug again NeXus in in this example as all the architecture present before is mantained in the current plugin code

anfiedler commented 1 year ago

Dear all,

we finally entered the test phase for the Hall schema and wanted to upload some data. Uploading some older data went well and works fine. However, we had a software update of our Hall software and now face some errors during the upload. This is due to the fact, that the output file slightly changed in style. In particular, they now display the charge carrier type in an extra column. I attached old (without charge carrier tyoe) and new (with charge carrier type) files for room temperature and temperature-dependent measurements, respectively.

Would you have time to help me with this? We could label the two different schemas with the Version numbers of the software: old(2.3) and new (3.12). 22-127-G_20K-320K_TT-Halter_WDH_060722.txt 22-127-G_Hall-RT_TT-Halter.txt 23-026-AG_Hall_RT.txt 22-211-G_Hall_23K-320K_TT-Halter.txt

aalbino2 commented 1 year ago

Hello Andreas, I'm glad you are testing the parser, among the one attached, which are the new files? Which lines should I look at for the charge carrier type?

Yes, we can develop a new version of the schema and label them with 2.3 and 3.12

Dear all,

we finally entered the test phase for the Hall schema and wanted to upload some data. Uploading some older data went well and works fine. However, we had a software update of our Hall software and now face some errors during the upload. This is due to the fact, that the output file slightly changed in style. In particular, they now display the charge carrier type in an extra column. I attached old (without charge carrier tyoe) and new (with charge carrier type) files for room temperature and temperature-dependent measurements, respectively.

Would you have time to help me with this? We could label the two different schemas with the Version numbers of the software: old(2.3) and new (3.12). 22-127-G_20K-320K_TT-Halter_WDH_060722.txt 22-127-G_Hall-RT_TT-Halter.txt 23-026-AG_Hall_RT.txt 22-211-G_Hall_23K-320K_TT-Halter.txt

anfiedler commented 1 year ago

Hello Andrea,

the new files are: 22-211-G_Hall_23K-320K_TT-Halter.txt and 23-026-AG_Hall_RT.txt

for: 23-026-AG_Hall_RT.txt the only change is in line 111, so in the sub-section: <Step 2: Variable Field Measurement>

for 22-211-G_Hall_23K-320K_TT-Halter.txt you can find it in line 46 to 61 for example in <step 1:Variable Temperature Measurement>. so it is in every "variable temperature measurement" and "variable field measurement"

Hello Andreas, I'm glad you are testing the parser, among the one attached, which are the new files? Which lines should I look at for the charge carrier type?

Yes, we can develop a new version of the schema and label them with 2.3 and 3.12

Dear all, we finally entered the test phase for the Hall schema and wanted to upload some data. Uploading some older data went well and works fine. However, we had a software update of our Hall software and now face some errors during the upload. This is due to the fact, that the output file slightly changed in style. In particular, they now display the charge carrier type in an extra column. I attached old (without charge carrier tyoe) and new (with charge carrier type) files for room temperature and temperature-dependent measurements, respectively. Would you have time to help me with this? We could label the two different schemas with the Version numbers of the software: old(2.3) and new (3.12). 22-127-G_20K-320K_TT-Halter_WDH_060722.txt 22-127-G_Hall-RT_TT-Halter.txt 23-026-AG_Hall_RT.txt 22-211-G_Hall_23K-320K_TT-Halter.txt

aalbino2 commented 1 year ago

I see, thanks

I will figure out the parsing of this new info.

In the meanwhile, if you have other comment concerning the data itself, or their visualization, just keep posting here,

Best, Andrea

anfiedler commented 1 year ago

Hello Andrea,

we also found a 2nd bug. In our room temperature measurements (we always write "Hall_RT" at the end of the filename) files (https://github.com/FAIRmat-NFDI/AreaA-data_modeling_and_schemas/files/11743963/23-026-AG_Hall_RT.txt) we have in the variable field measurement sometimes a temperature value and sometimes "ERROR" written (line 111). The thing is that we do not have a thermometer installed in our room temperature holder. So whatever the software saves is wrong. Additionally, the "ERROR" also prevents the parser to run the file. I think the best would be to not read out the temperature at all in the "variable field measurement". We would need to add the temperature as room temperature (something between 294 and 300 K) manually.

aalbino2 commented 1 year ago

I see, I will hence keep the temperature quantity in the ELN but I will not parse it from the logfiles. Thanks Andrea

aalbino2 commented 5 months ago
aalbino2 commented 3 months ago

@anfiedler check your email, you have been invited to the new IKZ github organization.

Keep following there the development of Hall. And also, let's schedule our meeting, thanks

aalbino2 commented 2 months ago

Opened issues:

https://github.com/IKZ-Berlin/lakeshore-nomad-plugin/issues/5

https://github.com/IKZ-Berlin/lakeshore-nomad-plugin/issues/4