FCCColumbus / fcc-columbus

FreeCodeCamp Columbus
https://fcccolumbus.com/
MIT License
25 stars 15 forks source link

Reduce size of resource icons and text #91

Closed tyday closed 6 years ago

tyday commented 6 years ago

Changed h2 to h3. Reduced width from 50% to 25% to allow for better flow.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 41450ee03f1da8939b6785ccefa87abd02b73079 on tyday:dev into d02f97e9431f3ab89a119e18d6628e4420c19b13 on FCCColumbus:dev.

jwoo92 commented 6 years ago

Lets split off the admin fix into another PR so we maintain a clean commit history.

Also, per #90, can we please remove the Twitch and YouTube links?

tyday commented 6 years ago

I don't know how to split off the Admin fix. It just keeps adding my commits to the pull request. :D

jwoo92 commented 6 years ago

Nice catch by the way on the admin stuff!

To make it easy, let's just reference the issue you created to keep note and can help get you situated to be a git master soon.

jwoo92 commented 6 years ago

@tyday If you can just remove the Twitch and Youtube links, we should be good to go.

tyday commented 6 years ago

I can do that.

However, I just went back and created a branch two commits ago. Would it be better if I did a pull request from there? And then followed it up with a second pull request?

https://github.com/tyday/F3C_Website/tree/Iss90

I would also need remove the links per your request.

jwoo92 commented 6 years ago

@tyday It is no big deal and I would not worry about it on this...just something to note for another issue in the future.