search

FDC3 / API

Open standards for the financial desktop.
https://fdc3.finos.org
Apache License 2.0
9 stars 9 forks source link

Should name in fdc3.open be an AppIdentifier? #17

Closed rikoe closed 6 years ago

rikoe commented 6 years ago

The comment for open(name: String, context: Context): Promise<void> says "Launches/links to an app by name".

Elsewhere (e.g. when sending an intent), type AppIdentifier = String is used. Is the "name" used in open the same as the app identifier used for intents? If it is the same, the same terminology should be used consistently.

If it is not the same, "name" needs to be explained in more detail to make the distinction clear. I would argue however that it should be the same app identifier used elsewhere if it is not, for the sake of API consistency.

In which case, it should probably be open(name: AppIdentifier, context: Context)

nkolba commented 6 years ago

For AppIdentifier and IntentName - let's change to String.

rikoe commented 6 years ago

Resolved by #26