search

FDC3 / ContextData

Open standards for the financial desktop.
https://fdc3.finos.org
Apache License 2.0
6 stars 5 forks source link

New context format with JSon schema and two sample data files #2

Closed lspiro-Tick42 closed 6 years ago

lspiro-Tick42 commented 6 years ago

This Pull request moves the Context data specification to match up with the current Intent definitions by allowing a data item (e.g. Instrument or Contact) to have multiple named formats (instead of just having a single data set with multiple field names).

This structure allows applications to register an Intent to only be relevant for a particular format of Instrument (for example only showing in-house position for an instrument if the Context holds the in-house instrument format ) NB An application Intent can be offered for multiple formats.

The Pull Request provides a JSon schema and two sample data files for this proposal.

lspiro-Tick42 commented 6 years ago

@finos-cla-bot[bot] check

maoo commented 6 years ago

Merging this PR, since @lspiro-Tick42 is indeed covered by CLA with FINOS. The CLA Bot is flagging this PR due to (apparently) a configuration issue (see https://github.com/ColinEberhardt/cla-bot/issues/74); we will reproduce the same issue on https://github.com/finos-fdx/odp-test

lspiro-Tick42 commented 6 years ago

Mao asked me to add an approve comment since he had to initiate the PR. I have not created a branch, since I don't know what our WG branching policy is. This PR consists of 3 new files so could easily be unwound or moved to a branch if required.

rikoe commented 6 years ago

In my opinion this PR should be unmerged as it was never discussed during a working group call. I do not agree with some of the changes added here.

ghost commented 6 years ago

The merge will be undone. Comments welcome on this PR.

maoo commented 6 years ago

Thanks @tkolecke . I'm happy to rollback the Pull Request for you , please let me know if/when to proceed.

The last commit before the PR is https://github.com/FDC3/ContextData/commit/be60e228d5b072d4c77559c2a134c881cfd713c2 and there are no further commits afterwards, therefore a simple git reset --soft https://github.com/FDC3/ContextData/commit/be60e228d5b072d4c77559c2a134c881cfd713c2 would work.

finos-admin commented 6 years ago

Rolling back master branch now, on commit https://github.com/FDC3/ContextData/commit/be60e228d5b072d4c77559c2a134c881cfd713c2

finos-admin commented 6 years ago

Rollback completed, see https://github.com/FDC3/ContextData/commits/master

/CC @tkolecke @rikoe