search

FERNman / angular-google-charts

A wrapper for the Google Charts library written in Angular.
Other
273 stars 107 forks source link

chore!: Angular 16 #321

Closed FERNman closed 3 weeks ago

FERNman commented 3 weeks ago

This branch bumps the minimum supported Angular version to 16 and should technically support Angular 16-18. Besides this important change, all the other outdated dependencies (mostly development-related) are updated.

Relates to #312

bittu-kumar-tfs commented 3 weeks ago

When this can be merged,

kevin-heneghan-tfs commented 3 weeks ago

Yes, we could use this as well!

bittu-kumar-tfs commented 3 weeks ago

Thanks for the merge, I am still getting some error from this package

Error: node_modules/angular-google-charts/lib/components/chart-editor/chart-editor-ref.d.ts:2:23 - error TS2688: Cannot find type definition file for 'projects/angular-google-charts/src/lib/components/chart-editor/chart-editor'.

2 /// 


Error: node_modules/angular-google-charts/lib/components/chart-editor/chart-editor-ref.d.ts:8:46 - error TS2694: Namespace 'google.visualization' has no exported member 'ChartEditor'.

8     constructor(editor: google.visualization.ChartEditor);

Error: node_modules/angular-google-charts/lib/components/chart-editor/chart-editor.component.d.ts:1:23 - error TS2688: Cannot find type definition file for 'projects/angular-google-charts/src/lib/components/chart-editor/chart-editor'.

1 /// 


Error: node_modules/angular-google-charts/lib/components/chart-editor/chart-editor.component.d.ts:15:72 - error TS2694: Namespace 'google.visualization' has no exported member 'ChartEditor'.

15     get initialized$(): import("rxjs").Observable<google.visualization.ChartEditor>;

Error: node_modules/angular-google-charts/lib/components/chart-editor/chart-editor.component.d.ts:25:67 - error TS2694: Namespace 'google.visualization' has no exported member 'ChartEditorOptions'.

25 editChart(component: ChartBase, options: google.visualization.ChartEditorOptions): ChartEditorRef;



can you help us quickly, We are stuck in angular project migration due to this.
FERNman commented 3 weeks ago

Hi @bittu-kumar-tfs, I'm sorry, this should be fixed in patch 16.0.1. Took me a while to figure out how to include my custom types in the production output.