FESOM / pyfesom

python library and tools for pre and post processing of the FESOM ocean model files
http://pyfesom.readthedocs.io/en/latest/index.html
MIT License
11 stars 6 forks source link

Defined cases for Atlantic, Indik, and Pacific Ocean in `plot_transect_map` #12

Open crodehacke opened 3 years ago

crodehacke commented 3 years ago

I would like to suggest to allow restricting the plot_transect_map to the three ocean basis.

plot_transect_map(lon_start, lat_start, lon_end, lat_end,
                      mesh, npoints=30, view = 'w', stock_img=False):
    :
    if view=='w':
      :
      :
    elif view=='atl':
        # Atlantic
        ax = plt.subplot(111, projection=ccrs.Mercator(central_longitude=0))
        ax.set_extent([25, -85, -75, 70], crs=ccrs.PlateCarree())
    elif view=='ind':
        # Indik
        ax = plt.subplot(111, projection=ccrs.Mercator(central_longitude=70))
        ax.set_extent([140, +15, -75, 30], crs=ccrs.PlateCarree())
    elif view=='pac':
        # Pacific
        ax = plt.subplot(111, projection=ccrs.Mercator(central_longitude=-180))
        ax.set_extent([-255, -70, -75, 67], crs=ccrs.PlateCarree())   
    else:
:
koldunovn commented 3 years ago

@crodehacke Can you try to do a PR with this changes?

crodehacke commented 3 years ago

Hej Nikolay,

I do not know what PR means. But maybe the attached Notebook helps.

All the best,

Christian


Christian Rodehacke

Danish Meteorological Institute Lyngbyvej 100 DK-2100 Copenhagen Ø Denmark

Email: cr@dmi.dk Tel: +45 3915 7453 Fax: +45 3915 1080

orcid.org/0000-0003-3110-3857


From: Nikolay Koldunov notifications@github.com Sent: Thursday, December 17, 2020 4:40:40 PM To: FESOM/pyfesom Cc: Christian Rodehacke; Mention Subject: Re: [FESOM/pyfesom] Defined cases for Atlantic, Indik, and Pacific Ocean in plot_transect_map (#12)

@crodehackehttps://github.com/crodehacke Can you try to do a PR with this changes?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/FESOM/pyfesom/issues/12#issuecomment-747517388, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AD7B4HXG3WCVL4NLJXHXJ63SVIQ7RANCNFSM4U722MWQ.

koldunovn commented 3 years ago

Hi @crodehacke

PR is Pool request, request to include your changes into the code of other people ( see e.g. https://guides.github.com/activities/hello-world/#pr). If it's easier for you just send me the notebook (by usual mail, attachments did not come automatically on GitHub).