search

FHIR / sql-on-fhir-v2

This project provides the source for the SQL on FHIR v2.0 Implementation Guide
https://build.fhir.org/ig/FHIR/sql-on-fhir-v2/
MIT License
103 stars 28 forks source link

Added EncounterFlat and ConditionFlat examples #260

Closed bashir2 closed 1 month ago

bashir2 commented 2 months ago

Added two examples from Open Health Stack flattening ViewDefinitions (specifically from here). Note that the publisher tool fails on this PR with an NPE as discussed/fixed in this other PR.

johngrimes commented 2 months ago

Thanks @bashir2!

This looks fine to me, but I feel like we should wait until the the fix makes it into the IG publisher before merging.

Otherwise I don't know how we can continue to build our IG successfully...

bashir2 commented 2 months ago

Thanks @bashir2!

This looks fine to me, but I feel like we should wait until the the fix makes it into the IG publisher before merging.

Otherwise I don't know how we can continue to build our IG successfully...

Thanks @johngrimes. Yeah that's correct; I won't merge this until my fix to the publisher tool is merged and released.

bashir2 commented 1 month ago

@johngrimes I think the publisher tool has been finally fixed/released and I think we can merge this PR now (the publisher tool does not produce the NPE on this change anymore). I know you are in the process of generating a release candidate for SQL-on-FHIR IG, so please merge this when the time is right.