Add `servicepack` and `extensionpack` to `fix` element of generated data dictionary - Githubissues

FIXTradingCommunity / fix-orchestra-quickfix

FIX Orchestra / QuickFIX integration

Apache License 2.0

3 stars 5 forks source link

Add `servicepack` and `extensionpack` to `fix` element of generated data dictionary #1

Closed donmendelson closed 3 years ago

donmendelson commented 3 years ago

Move issue https://github.com/FIXTradingCommunity/fix-orchestra/issues/106 to this project.

chrjohn commented 3 years ago

Hi @donmendelson , could you transfer that issue to this project? I don't have the permission to do so.

donmendelson commented 3 years ago

In FIXTradingCommunity/fix-orchestra @chrjohn said:

Currently the DataDictionaryGenerator generates only the major and minor version in the fix element.

https://github.com/FIXTradingCommunity/fix-orchestra/blob/3569faa06840472b649c447007f23d9ad36651d5/repository-quickfix/src/main/java/io/fixprotocol/orchestra/quickfix/DataDictionaryGenerator.java#L167-L168

This should be extended by at least servicepack and even better also extensionpack. As far as I can see this information is available in the repository: https://github.com/FIXTradingCommunity/fix-orchestra/blob/3569faa06840472b649c447007f23d9ad36651d5/repository-quickfix/src/main/java/io/fixprotocol/orchestra/quickfix/DataDictionaryGenerator.java#L149

The data dictionaries of QuickFIX (C++) already contain the servicepack attribute (it is 0 for non-SP versions): http://www.quickfixengine.org/FIX50SP1.xml http://www.quickfixengine.org/FIX50.xml