search

FIXTradingCommunity / fix-simple-binary-encoding

A FIX standard for binary message encoding
Other
263 stars 69 forks source link

Sample order message schema typos #27

Closed VadimKey closed 7 years ago

VadimKey commented 8 years ago

https://github.com/FIXTradingCommunity/fix-simple-binary-encoding/blob/master/v1-0-RC4/doc/07Examples.md

  1. In XML schema there is an extra character '`' in the first line:

`<?xml version="1.0" encoding="UTF-8" standalone="yes"?>``

  1. xmllint and other tools complain:

$ xmllint flat-fixed.xml flat-fixed.xml:6: namespace error : Namespace prefix xsi for schemaLocation on messageSchema is not defined xsi:schemaLocation="http://fixprotocol.io/sbe/rc4SimpleBinary1-0.xsd"> ^

To fix it either xsi:schemaLocation should be changed to "xs:schemaLocation" either "xmlns:xs="http://www.w3.org/2001/XMLSchema-instance" should be changed to "xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance".

donmendelson commented 8 years ago

Thanks for careful checking, @VadimKey. We will update Final Standard if there are only minor corrections. More substantial changes would require a new version.

donmendelson commented 8 years ago

A baseline was pushed for Draft Standard errata. I already corrected schema location in Examples.xml to: `xsi:schemaLocation="http://fixprotocol.io/2016/sbe sbe.xsd"

Documentation still needs to be updated to use the new namespace and XSD file name instead of the RC4 names.