search

FLVC / flvc

FLVC-specific Islandora Hooks
0 stars 2 forks source link

Bug in the MODS Simple Entry form: physicalLocation and PURL entered together causes a validation error #68

Closed wrandtkeflvc closed 5 months ago

wrandtkeflvc commented 7 years ago

In the MODS Simple Entry form, under the "Location" section, entering both "Physical location" and a PURL in the same <location> field will result in a validation error.

Form fix: I'm not sure what the fix would be other than to split out PURL from URL and have two blocks with a longer form.

Check of metadata across sites: This bug has been in the form since Islandora was first set up. Probably there are some affected records and there should be a check for those.

wrandtkeflvc commented 7 years ago

This is CRM case no. CAS-88189-C8B0

wrandtkeflvc commented 5 years ago

This problem with the field and validation is caused because subelements of are sequenced in MODS.

I think that this self tranform https://github.com/Islandora/islandora_xml_forms/blob/7.x/builder/self_transforms/islandora_cleanup_mods_extended.xsl has a section that sequences the subelements within . If those get sequenced, then the MODS will validate.

Fix is probably to take that bit of sequencing and put it into FLVC's self transform. Then over time, as MODS is edited with the forms, any edit to a record will fix this problem for that field.

wrandtkeflvc commented 5 years ago

A couple of other relevant github links: Commit that added the above sequencing: https://github.com/Islandora/islandora_xml_forms/pull/231/files

Ordering elements in MARC xml: https://github.com/mnylc/islandora_marcxml/commit/83b7b703572d5027ec66a0b4469cf32683b77db7

wrandtkeflvc commented 5 years ago

On the development server, the post processing is located at /usr/local/islandora/FLVC_Islandora_XSLTs/FLVC_MODS_postprocessing.xsl

This is tracked in github at https://github.com/FLVC/FLVC_Islandora_XSLTs/blob/master/FLVC_MODS_postprocessing.xsl