search

FRC2706 / 2017-2706-Robot-Code

The main robot code for our 2017 Steamworks robot.
3 stars 3 forks source link

Bling and StickRumble fixes and additions #38

Closed KyleRAnderson closed 7 years ago

KyleRAnderson commented 7 years ago

Optimized the bling susbsytem for battery displaying, added a battery level calculator (very approximate). StickRumble command also has an added interval feature and works as it should now.

All has been tested on plyboy. Bling subsystem will not work on Mergius, therefore meaning the battery indications must be turned off.

KyleRAnderson commented 7 years ago

Need to wait on #48 to have the new features outlined.

ryanlarkin commented 7 years ago

Just deploy the code, you don't need to be connected to the robot, then restart eclipse

On Feb 26, 2017 1:54 PM, "Kyle Anderson" notifications@github.com wrote:

@eAUE commented on this pull request.

In .classpath https://github.com/FRC2706/2017-2706-Robot-Code/pull/38#discussion_r103112814 :

@@ -11,7 +11,5 @@

Eclipse did it automatically. I don't seem to have the proper modules for them installed. How can I get them installed?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHub https://github.com/FRC2706/2017-2706-Robot-Code/pull/38#discussion_r103112814, or mute the thread https://github.com/notifications/unsubscribe-auth/AFhS7ZsLjGOaxI-jS0vi_rqLY3O2j__-ks5rgcpqgaJpZM4MFPke .

KyleRAnderson commented 7 years ago

I made a seperate command to replace teleopPeriodic, but clear, teleopInit and auto are all only run once so I didn't think it was worth it.

ryanlarkin commented 7 years ago

If possible, I'd still want to keep Robot as minimal as possible, so I made a small change to the command, not sure if it works though. eAUE#2

ryanlarkin commented 7 years ago

@eAUE, is this ready to be merged, or does it need testing?

KyleRAnderson commented 7 years ago

It needs to be tested. I'm going to be at the KRP to do that today.

KyleRAnderson commented 7 years ago

@eandr127 @Stealth2994 can you guys put the new robot code with the new controller mappings on GitHub by the way for drive practise later today? Thanks!

ryanlarkin commented 7 years ago

It's currently in GearWallAlignment branch, I can hopefully have it merged into master by 1.

On Mar 5, 2017 11:41 AM, "Kyle Anderson" notifications@github.com wrote:

@eandr127 https://github.com/eandr127 @Stealth2994 https://github.com/Stealth2994 can you guys put the new robot code with the new robot mappings on GitHub by the way for drive practise later today? Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/FRC2706/2017-2706-Robot-Code/pull/38#issuecomment-284242002, or mute the thread https://github.com/notifications/unsubscribe-auth/AFhS7e6z2mSGvziWSuwQiBMGl5HSuVMZks5riuWxgaJpZM4MFPke .

KyleRAnderson commented 7 years ago

@eandr127 @Stealth2994 so all of my code is working now, but I have the new stuff from the practice branch in here as well. I'll wait for you guys to merge that before I merge this.

cnnradams commented 7 years ago

I think this is ready to be merged... lol :)

KyleRAnderson commented 7 years ago

Yeah, just before we do that how accurate is the IR sensor at detecting when the peg is in the hole?

KyleRAnderson commented 7 years ago

I guess it doesn't really matter. I'll merge it.