FRosner / spawncamping-dds

Data-Driven Spark allows quick data exploration based on Apache Spark.
Other
28 stars 15 forks source link

Replace all visualizations with dds.js #291

Open Gerrrr opened 8 years ago

Gerrrr commented 8 years ago

Solution for: https://github.com/FRosner/spawncamping-dds/issues/289

codecov-io commented 8 years ago

Current coverage is 94.76%

Merging #291 into master will not affect coverage as of 550b1fe

@@            master    #291   diff @@
======================================
  Files           20      20       
  Stmts         1185    1185       
  Branches       147     147       
  Methods          0       0       
======================================
  Hit           1123    1123       
  Partial          0       0       
  Missed          62      62       

Review entire Coverage Diff as of 550b1fe

Powered by Codecov. Updated on successful CI builds.

FRosner commented 8 years ago

@Gerrrr I think codacy will complain a lot less if you name your dds.js dds.min.js.

Gerrrr commented 8 years ago

@FRosner done

FRosner commented 8 years ago

@Gerrrr except for the one remaining issue in Visualization.js codacy is happy. I will check the branch out, build it and give it a try in the next days. Thanks a lot!

Gerrrr commented 8 years ago

@FRosner, PR is ready for review, please ignore codacy complaints.

FRosner commented 8 years ago

Thanks for the pull request @Gerrrr. After executing the core/src/test/resources/manual-tests.txt I have the following comments. Please find the respective line numbers in the headlines of each issue.

Canvas Size (L: 14, 15, ...)

image

image

Dashboard Blocking the UI (L: 19)

Summary Composite Overplotting (L: 20)

image

image

Heatmap with NaN not Displayed (L: 21)

Scatterplot (L: 26)

Key Value Pairs (L: 27)

image

Table Not Drawn (L: 97)

Visualization Title Positioning

Graph Buttons Wrong (L: 14)

image

Graph Redrawing

Overall Performance

Gerrrr commented 8 years ago

I fixed the issues you mentioned above. Can you please review it again?

FRosner commented 8 years ago

I released DDQ 3.0.0 today and will take a look at it in the next days @Gerrrr. Thanks!

FRosner commented 8 years ago

WIP

image