Open Gerrrr opened 8 years ago
94.76%
Merging #291 into master will not affect coverage as of
550b1fe
@@ master #291 diff @@
======================================
Files 20 20
Stmts 1185 1185
Branches 147 147
Methods 0 0
======================================
Hit 1123 1123
Partial 0 0
Missed 62 62
Review entire Coverage Diff as of
550b1fe
Powered by Codecov. Updated on successful CI builds.
@Gerrrr I think codacy will complain a lot less if you name your dds.js
dds.min.js
.
@FRosner done
@Gerrrr except for the one remaining issue in Visualization.js
codacy is happy. I will check the branch out, build it and give it a try in the next days. Thanks a lot!
@FRosner, PR is ready for review, please ignore codacy complaints.
Thanks for the pull request @Gerrrr. After executing the core/src/test/resources/manual-tests.txt
I have the following comments. Please find the respective line numbers in the headlines of each issue.
I fixed the issues you mentioned above. Can you please review it again?
I released DDQ 3.0.0 today and will take a look at it in the next days @Gerrrr. Thanks!
WIP
[info] Loading /Users/frosner/Documents/projects/spawncamping-dds/web-ui/src/main/resources/ui/app/require.config.js Could not read file: /Users/frosner/Documents/projects/spawncamping-dds/web-ui/src/main/resources/ui/app/require.config.js error was: InternalError: Couldn't read source file "./../lib/d3.v3.min.js": ./../lib/d3.v3.min.js (No such file or directory). (rjs/r-2.0.1.js#2110)
show(sqlGolf)
just scrolls into nirvana.dashboard(sqlFlights.select("flightDate", "carrier", "carrierDelay"))
breaks my browser...
Solution for: https://github.com/FRosner/spawncamping-dds/issues/289