FTBTeam / FTB-Interactions

14 stars 10 forks source link

ArchitectureCraft - Chiseling out a glass pane from a window frame crashes the game #1362

Closed CaptainFord closed 2 years ago

CaptainFord commented 3 years ago

Modpack Version:

2.0.9

Bug Report:

Crash on chiseling a glass pane out of an ArchitectureCraft window frame by right-clicking on the window with an ArchitectureCraft chisel. Consistent. Happened three out of three times.

In a fresh game, the same action did not cause a crash, but did cause the "An unknown problem occurred!" message in the upper-right corner. These crash logs are different from the first three, and all appear to be caused by a null pointer exception at java.util.concurrent.FutureTask.report(FutureTask.java:122). It generates multiple such logs, a few seconds apart (a total of 55 crash logs for 7 to 9 panes removed).

While recording the video, also in a fresh game, it crashed to the title screen instead of giving me "An unknown problem occurred!". I don't know what the difference is. It also generated 7 crash log files for the single event each timestamped a few seconds apart. All of these logs were also NullPointerExceptions at java.util.concurrent.FutureTask.report(FutureTask.java:122).

It is worth noting that aside from crashing, the chisel works as expected. The pane is removed from the frame, and can be picked up after reloading the game.

Expected Behavior/Suggestions:

Using the ArchitectureCraft chisel to remove a window pane from a window frame should not crash the game.

Is It Repeatable? Steps to Reproduce:

Video: https://youtu.be/pJQN5Z2R29Y

  1. Start a new world in Creative mode
  2. Throw all your starting guidebooks into the void
  3. Retrieve four items: a. An ArchitectureCraft Sawbench b. Any solid block (cobblestone, diorite, etc.) c. A vanilla glass pane (any color) d. An ArchitectureCraft chisel
  4. Place the Sawbench
  5. Use the Sawbench to make a window frame
  6. Place the glass pane into the window frame
  7. Remove the glass pane from the window frame by right-clicking with the chisel. This should cause a crash.

Link to Log or Crash File Paste**:

First Crash (Server): https://paste.feed-the-beast.com/view/254b1ee9 Second Crash (Server): https://paste.feed-the-beast.com/view/04e8a111 Second Crash (Client): https://paste.feed-the-beast.com/view/f7194e11 Fresh Game Crash Logs Log - Game recovers (Server): https://paste.feed-the-beast.com/view/ba2df5ed

Mod/s Affected:

ArchitectureCraft

Known Fix

Someone produced a quick-fix for this, or a similar issue here: https://github.com/TridentMC/ArchitectureCraft/issues/80

Saereth commented 2 years ago

next version updates to the experimental version build with this fix