FWGS / xash3d-fwgs

Xash3D FWGS engine
1.59k stars 242 forks source link

[Android] Incorrect chapter title #320

Closed MJ32768 closed 3 years ago

MJ32768 commented 3 years ago

The chapter "Forget About Freeman" turned into "On You Own" incorrectly in game , but in "titles.txt" , it's still "FORGET ABOUT FREEMAN!" , the problem really sucks , please help🙏 Screenshot_20210224-115124 Screenshot_20210224-115235

MJ32768 commented 3 years ago

Exactly , only if when I load or save game can I see the strange "On Your Own" , if I change chapters when playing game , it will correctly displays "FORGET ABOUT FREEMAN" in the right area of screen for a few seconds ( I'm a Chinese student , my English is not very good ), so let me know if you get any ideas about the problem.

lewa-j commented 3 years ago

Did you tested it on GoldSrc?

MJ32768 commented 3 years ago

您是否在GoldSrc上测试过?

Not yet, I play the official steam version in PC and use Xash3D Android port to play half life

MJ32768 commented 3 years ago

I mean……, I haven't tried PC version of Xash yet

a1batross commented 3 years ago

I looked what GoldSrc does:

  1. It searches for SV_SaveGameComment export in server dll. If it's found, it's being used to generate save chapter title. Xash does the same.
  2. If it's not found, the engine provided version is used. And there is the difference: GoldSrc has hardcoded map name to title key dictionary, when Xash reads "message" key of world entity.

The fix is obvious, we need take that hardcoded dictionary and use it.

MJ32768 commented 3 years ago

I looked what GoldSrc does:

  1. It searches for SV_SaveGameComment export in server dll. If it's found, it's being used to generate save chapter title. Xash does the same.
  2. If it's not found, the engine provided version is used. And there is the difference: GoldSrc has hardcoded map name to title key dictionary, when Xash reads "message" key of world entity.

The fix is obvious, we need take that hardcoded dictionary and use it.

So what files do you need? Here is my "titles.txt" : https://drive.google.com/file/d/1Z4PJgjtF083AK3z5cja8gpffNPfDxeWd/view?usp=sharing

a1batross commented 3 years ago

Zero, I already fixed it. Testing it and gonna push the fix.

MJ32768 commented 3 years ago

Zero, I already fixed it. Testing it and gonna push the fix.

I completed the game with Xash FWGS today, only the chapter "Forget About Freeman" has the strange titles in the "Save/load game " interface

MJ32768 commented 3 years ago

And when I watch the end credits after the chapter "End game", it played music for a few seconds and suddenly stopped , maybe it's the problem of my device, but I just can't enioy the full music! I know it is unsuitable to put forward a new issue here , however, it should also be solved: Screenshot_20210226-171921 35e86601e85aaa3

a1batross commented 3 years ago

One bug = one report.

MJ32768 commented 3 years ago

Sure, you are right.

BlackShadow commented 3 years ago

On Your Own is the "Beta" title for Forget About Freeman. It's inside of the BSP file. Xash probably read it inside the BSP file instead of titles.txt