search

FabricMC / fabric-example-mod

Example Fabric mod
Creative Commons Zero v1.0 Universal
1.66k stars 940 forks source link

Update to Gradle 7.6 #222

Closed altrisi closed 1 year ago

altrisi commented 1 year ago

This PR updates Gradle and the wrapper to 7.6. This is the result of running the command gradlew wrapper --gradle-version=7.6.

I wanted to update the wrapper too given 7.6 fixed a 5 year old issue where the wrapper would also keep the zip of every used Gradle version after extracting it, with each zip being ~100MB (over that in recent versions). It should now be deleted after extraction (gradle/gradle#19495).

Doing so not only uses less space in modder's drives, but also can (slightly) speed up github actions cache downloads given that zip can be a significant part of the cache (around 25% in carpet for example unless I was missing something).

modmuss50 commented 1 year ago

Something isnt right with this PR, when I ran the upgrade on my machine I got a different result: https://github.com/FabricMC/fabric-example-mod/pull/223 This PR updates the wrapper jar, while mine does not? Edit, mine did im just blind, still not the same diff

altrisi commented 1 year ago

Strange, quite sure I changed nothing, feel free to just push that then, tbh all I really want is for that bug to not affect me or anyone when starting a new mod.

PS: Maybe the diff is different because it was made from a different origin version? Idk

modmuss50 commented 1 year ago

Ah, figured it out, I first ran it from 7.5, re-running the same command from 7.6 gives the same results that you got. That is super weird...