Only open JAR files if the provided input is a directory

FabricMC / tiny-remapper

Tiny JAR remapping tool.

GNU Lesser General Public License v3.0

115 stars 65 forks source link

Only open JAR files if the provided input is a directory #101

Open TheGlitch76 opened 2 years ago

TheGlitch76 commented 2 years ago

This PR removes some surprising behavior involving scanning JARs.

Previously, when presented with a JAR file, Tiny Remapper would open all of its nested JAR files and treat every file as an input. However, it would not re-construct the file structure. Instead, in the output it would flatten all nested JARs into the top jar, and create conflicts if the user had also added the nested JAR as an input.

This PR reverts that behavior, and makes Tiny Remapper ignore nested JARs.

sfPlayer1 commented 2 years ago

The behavior definitely need to change, not sure how exactly yet though. It'd theoretically be possible to (optionally) handle nested jars through sub-input-tags.