FabricMC / tiny-remapper

Tiny JAR remapping tool.
GNU Lesser General Public License v3.0
115 stars 65 forks source link

Support local variable remapping #114

Open NebelNidas opened 1 year ago

NebelNidas commented 1 year ago

Not sure why this wasn't enabled yet, from my (arguably limited) testing it looks like everything's working correctly.

SpaceWalkerRS commented 1 year ago

I remember there being an issue with some obfuscated jars, since they lack a local variable table in the byte code. In that case this remapping would fail. I don't know if it's doable for TR to generate this byte code if any local variable mappings are given?

cph101 commented 8 months ago

This pull request is so simple, yet a total lifesaver. Thank you so much for implementing this! 🙏

NebelNidas commented 7 months ago

I don't know if it's doable for TR to generate this

Apparently there's some rudimentary code for LVT generation in Matcher, I'll see if I can repurpose it. That's going to be another PR though, the current changes already work perfectly fine for methods with intact LVT attributes