search

Fabricators-of-Create / Create

[Fabric Mod] Building Tools and Aesthetic Technology
MIT License
894 stars 200 forks source link

Recipe for smelting zinc from raw zinc ore is broken #1639

Closed oxideNeko233 closed 5 days ago

oxideNeko233 commented 6 days ago

Description

Recipe for smelting zinc from raw zinc ore is broken, also blasting and bulk blasting.

image

Game Log

https://mclo.gs/FXafl4x

Debug Information

Client Info ``` Create: Mod Version: 0.5.1j Fabric API Version: 0.92.2+1.20.1 Minecraft Version: 1.20.1 Graphics: Flywheel Version: 0.6.11-4 Flywheel Backend: INSTANCING OpenGL Renderer: AMD Radeon 780M Graphics OpenGL Version: 3.2.0 Core Profile Context 24.10.1.241007 Graphics Mode: options.graphics.fancy System Information: Operating System: Windows 11 (amd64) version 10.0 Java Version: 17.0.12, Oracle Corporation JVM Flags: 6 total; -XX:ThreadPriorityPolicy=1 -XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCIProduct -XX:-UnlockExperimentalVMOptions -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xmx8192M Memory: 1113639984 bytes (1062 MiB) / 2248146944 bytes (2144 MiB) up to 8589934592 bytes (8192 MiB) Total Memory: 19831197696 bytes (18904 MiB) / 33515835392 bytes (31950 MiB) CPU: AMD Ryzen 9 7940HS w/ Radeon 780M Graphics @ 3.99 GHz; 8 cores / 16 threads on 1 socket(s) Graphics card #0: AMD Radeon 780M Graphics (Advanced Micro Devices, Inc. (0x1002)); 512.00 MB of VRAM Other Mods: core: 3.6.6 toml: 3.6.6 jsr305: 3.0.2 Dripstone Fluid Lib: 3.0.2 EMI: 1.1.18+1.20.1+fabric Extra Mod Integrations: 0.4.6+1.20.1 Fabric API Base: 0.4.31+1802ada577 Fabric API Lookup API (v1): 1.6.36+1802ada577 Fabric Biome API (v1): 13.0.13+1802ada577 Fabric Block API (v1): 1.0.11+1802ada577 Fabric BlockView API (v2): 1.0.1+1802ada577 Fabric BlockRenderLayer Registration (v1): 1.1.41+1802ada577 Fabric Client Tags: 1.1.2+1802ada577 Fabric Command API (v1): 1.2.34+f71b366f77 Fabric Command API (v2): 2.2.13+1802ada577 Fabric Commands (v0): 0.2.51+df3654b377 Fabric Containers (v0): 0.1.64+df3654b377 Fabric Content Registries (v0): 4.0.11+1802ada577 Fabric Convention Tags: 1.5.5+1802ada577 Fabric Crash Report Info (v1): 0.2.19+1802ada577 Fabric Data Attachment API (v1): 1.0.0+de0fd6d177 Fabric Data Generation API (v1): 12.3.4+1802ada577 Fabric Dimensions API (v1): 2.1.54+1802ada577 Fabric Entity Events (v1): 1.6.0+1c78457f77 Fabric Events Interaction (v0): 0.6.2+1802ada577 Fabric Events Lifecycle (v0): 0.2.63+df3654b377 Fabric Game Rule API (v1): 1.0.40+1802ada577 Fabric Item API (v1): 2.1.28+1802ada577 Fabric Item Group API (v1): 4.0.12+1802ada577 Fabric Key Binding API (v1): 1.0.37+1802ada577 Fabric Key Bindings (v0): 0.2.35+df3654b377 Fabric Lifecycle Events (v1): 2.2.22+1802ada577 Fabric Loot API (v2): 1.2.1+1802ada577 Fabric Loot Tables (v1): 1.1.45+9e7660c677 Fabric Message API (v1): 5.1.9+1802ada577 Fabric Mining Level API (v1): 2.1.50+1802ada577 Fabric Model Loading API (v1): 1.0.3+1802ada577 Fabric Models (v0): 0.4.2+9386d8a777 Fabric Networking API (v1): 1.3.11+1802ada577 Fabric Networking (v0): 0.3.51+df3654b377 Fabric Object Builder API (v1): 11.1.3+1802ada577 Fabric Particles (v1): 1.1.2+1802ada577 Fabric Recipe API (v1): 1.0.21+1802ada577 Fabric Registry Sync (v0): 2.3.3+1802ada577 Fabric Renderer API (v1): 3.2.1+1802ada577 Fabric Renderer - Indigo: 1.5.2+85287f9f77 Fabric Renderer Registries (v1): 3.2.46+df3654b377 Fabric Rendering Data Attachment (v1): 0.3.37+92a0d36777 Fabric Rendering Fluids (v1): 3.0.28+1802ada577 Fabric Rendering (v0): 1.1.49+df3654b377 Fabric Rendering (v1): 3.0.8+1802ada577 Fabric Resource Conditions API (v1): 2.3.8+1802ada577 Fabric Resource Loader (v0): 0.11.10+1802ada577 Fabric Screen API (v1): 2.0.8+1802ada577 Fabric Screen Handler API (v1): 1.3.30+1802ada577 Fabric Sound API (v1): 1.0.13+1802ada577 Fabric Transfer API (v1): 3.3.5+8dd72ea377 Fabric Transitive Access Wideners (v1): 4.3.1+1802ada577 Fabric Loader: 0.16.9 Forge Config API Port: 8.0.0 Java HotSpot(TM) 64-Bit Server VM: 17 Milk Lib: 1.2.60 MixinExtras: 0.4.1 Porting Lib Accessors: 2.3.5-beta.33+1.20.1 Porting Lib Attributes: 2.3.5-beta.33+1.20.1 Porting Lib Base: 2.3.5-beta.33+1.20.1 Porting Lib Brewing: 2.3.5-beta.33+1.20.1 Porting Lib Client Events: 2.3.5-beta.33+1.20.1 Porting Lib Common: 2.3.5-beta.33+1.20.1 Porting Lib Config: 2.3.5-beta.33+1.20.1 Porting Lib Core: 2.3.5-beta.33+1.20.1 Porting Lib Data: 2.1.1090+1.20 Porting Lib Entity: 2.3.5-beta.33+1.20.1 Porting Lib Extensions: 2.3.5-beta.33+1.20.1 Porting Lib Fluids: 2.3.5-beta.33+1.20.1 Porting Lib GameTest: 2.1.1090+1.20 Porting Lib Gui Utils: 2.3.5-beta.33+1.20.1 Porting Lib Lazy Register: 2.3.5-beta.33+1.20.1 Porting Lib Mixin Extensions: 2.3.5-beta.33+1.20.1 Porting Lib Model Generators: 2.1.1090+1.20 Porting Lib Model Loader: 2.3.5-beta.33+1.20.1 Porting Lib Model Materials: 2.1.1090+1.20 Porting Lib Models: 2.3.5-beta.33+1.20.1 Porting Lib Networking: 2.3.5-beta.33+1.20.1 Porting Lib Obj Loader: 2.3.5-beta.33+1.20.1 Porting Lib Tags: 3.0 Porting Lib Tool Actions: 2.3.5-beta.33+1.20.1 Porting Lib Transfer: 2.3.5-beta.33+1.20.1 Porting Lib Utility: 2.3.5-beta.33+1.20.1 Reach Entity Attributes: 2.4.0 Registrate for Fabric: 1.3.79-MC1.20.1 ```
Server Info ``` Create: Mod Version: 0.5.1j Fabric API Version: 0.92.2+1.20.1 Minecraft Version: 1.20.1 System Information: Operating System: Windows 11 (amd64) version 10.0 Java Version: 17.0.12, Oracle Corporation JVM Flags: 6 total; -XX:ThreadPriorityPolicy=1 -XX:+UnlockExperimentalVMOptions -XX:+EnableJVMCIProduct -XX:-UnlockExperimentalVMOptions -XX:HeapDumpPath=MojangTricksIntelDriversForPerformance_javaw.exe_minecraft.exe.heapdump -Xmx8192M Memory: 1113639984 bytes (1062 MiB) / 2248146944 bytes (2144 MiB) up to 8589934592 bytes (8192 MiB) Total Memory: 19831197696 bytes (18904 MiB) / 33515835392 bytes (31950 MiB) CPU: AMD Ryzen 9 7940HS w/ Radeon 780M Graphics @ 3.99 GHz; 8 cores / 16 threads on 1 socket(s) Graphics card #0: AMD Radeon 780M Graphics (Advanced Micro Devices, Inc. (0x1002)); 512.00 MB of VRAM Other Mods: core: 3.6.6 toml: 3.6.6 jsr305: 3.0.2 Dripstone Fluid Lib: 3.0.2 EMI: 1.1.18+1.20.1+fabric Extra Mod Integrations: 0.4.6+1.20.1 Fabric API Base: 0.4.31+1802ada577 Fabric API Lookup API (v1): 1.6.36+1802ada577 Fabric Biome API (v1): 13.0.13+1802ada577 Fabric Block API (v1): 1.0.11+1802ada577 Fabric BlockView API (v2): 1.0.1+1802ada577 Fabric BlockRenderLayer Registration (v1): 1.1.41+1802ada577 Fabric Client Tags: 1.1.2+1802ada577 Fabric Command API (v1): 1.2.34+f71b366f77 Fabric Command API (v2): 2.2.13+1802ada577 Fabric Commands (v0): 0.2.51+df3654b377 Fabric Containers (v0): 0.1.64+df3654b377 Fabric Content Registries (v0): 4.0.11+1802ada577 Fabric Convention Tags: 1.5.5+1802ada577 Fabric Crash Report Info (v1): 0.2.19+1802ada577 Fabric Data Attachment API (v1): 1.0.0+de0fd6d177 Fabric Data Generation API (v1): 12.3.4+1802ada577 Fabric Dimensions API (v1): 2.1.54+1802ada577 Fabric Entity Events (v1): 1.6.0+1c78457f77 Fabric Events Interaction (v0): 0.6.2+1802ada577 Fabric Events Lifecycle (v0): 0.2.63+df3654b377 Fabric Game Rule API (v1): 1.0.40+1802ada577 Fabric Item API (v1): 2.1.28+1802ada577 Fabric Item Group API (v1): 4.0.12+1802ada577 Fabric Key Binding API (v1): 1.0.37+1802ada577 Fabric Key Bindings (v0): 0.2.35+df3654b377 Fabric Lifecycle Events (v1): 2.2.22+1802ada577 Fabric Loot API (v2): 1.2.1+1802ada577 Fabric Loot Tables (v1): 1.1.45+9e7660c677 Fabric Message API (v1): 5.1.9+1802ada577 Fabric Mining Level API (v1): 2.1.50+1802ada577 Fabric Model Loading API (v1): 1.0.3+1802ada577 Fabric Models (v0): 0.4.2+9386d8a777 Fabric Networking API (v1): 1.3.11+1802ada577 Fabric Networking (v0): 0.3.51+df3654b377 Fabric Object Builder API (v1): 11.1.3+1802ada577 Fabric Particles (v1): 1.1.2+1802ada577 Fabric Recipe API (v1): 1.0.21+1802ada577 Fabric Registry Sync (v0): 2.3.3+1802ada577 Fabric Renderer API (v1): 3.2.1+1802ada577 Fabric Renderer - Indigo: 1.5.2+85287f9f77 Fabric Renderer Registries (v1): 3.2.46+df3654b377 Fabric Rendering Data Attachment (v1): 0.3.37+92a0d36777 Fabric Rendering Fluids (v1): 3.0.28+1802ada577 Fabric Rendering (v0): 1.1.49+df3654b377 Fabric Rendering (v1): 3.0.8+1802ada577 Fabric Resource Conditions API (v1): 2.3.8+1802ada577 Fabric Resource Loader (v0): 0.11.10+1802ada577 Fabric Screen API (v1): 2.0.8+1802ada577 Fabric Screen Handler API (v1): 1.3.30+1802ada577 Fabric Sound API (v1): 1.0.13+1802ada577 Fabric Transfer API (v1): 3.3.5+8dd72ea377 Fabric Transitive Access Wideners (v1): 4.3.1+1802ada577 Fabric Loader: 0.16.9 Forge Config API Port: 8.0.0 Java HotSpot(TM) 64-Bit Server VM: 17 Milk Lib: 1.2.60 MixinExtras: 0.4.1 Porting Lib Accessors: 2.3.5-beta.33+1.20.1 Porting Lib Attributes: 2.3.5-beta.33+1.20.1 Porting Lib Base: 2.3.5-beta.33+1.20.1 Porting Lib Brewing: 2.3.5-beta.33+1.20.1 Porting Lib Client Events: 2.3.5-beta.33+1.20.1 Porting Lib Common: 2.3.5-beta.33+1.20.1 Porting Lib Config: 2.3.5-beta.33+1.20.1 Porting Lib Core: 2.3.5-beta.33+1.20.1 Porting Lib Data: 2.1.1090+1.20 Porting Lib Entity: 2.3.5-beta.33+1.20.1 Porting Lib Extensions: 2.3.5-beta.33+1.20.1 Porting Lib Fluids: 2.3.5-beta.33+1.20.1 Porting Lib GameTest: 2.1.1090+1.20 Porting Lib Gui Utils: 2.3.5-beta.33+1.20.1 Porting Lib Lazy Register: 2.3.5-beta.33+1.20.1 Porting Lib Mixin Extensions: 2.3.5-beta.33+1.20.1 Porting Lib Model Generators: 2.1.1090+1.20 Porting Lib Model Loader: 2.3.5-beta.33+1.20.1 Porting Lib Model Materials: 2.1.1090+1.20 Porting Lib Models: 2.3.5-beta.33+1.20.1 Porting Lib Networking: 2.3.5-beta.33+1.20.1 Porting Lib Obj Loader: 2.3.5-beta.33+1.20.1 Porting Lib Tags: 3.0 Porting Lib Tool Actions: 2.3.5-beta.33+1.20.1 Porting Lib Transfer: 2.3.5-beta.33+1.20.1 Porting Lib Utility: 2.3.5-beta.33+1.20.1 Reach Entity Attributes: 2.4.0 Registrate for Fabric: 1.3.79-MC1.20.1 ```
VoidLeech commented 5 days ago

Tag mismatch, the recipe is using https://github.com/Fabricators-of-Create/Create/blob/0f58b606f1301fc742367c8ed79d3fc080ee6610/src/generated/resources/data/create/recipes/smelting/zinc_ingot_from_raw_ore.json#L7 on all three dev branches. This tag is only present on mc1.18/fabric/dev, the other two still assign raw zinc to c:raw_zinc_ores (ex: https://github.com/Fabricators-of-Create/Create/blob/mc1.20.1/fabric/dev/src/generated/resources/data/c/tags/items/raw_zinc_ores.json)

Imo a bit odd to have switched to the new shared loader tag format for these versions when Fabric itself doesn't seem to have backported them.

IThundxr commented 5 days ago

This was likely caused by a bad merge of that class, the switch wasn't intentional