FaceFX / FaceFX-UE4

The FaceFX Unreal Engine 4 plugin.
Other
170 stars 63 forks source link

Negative-time keys cause end of audio to be clipped in Sequencer #142

Closed dpakatheman closed 6 years ago

dpakatheman commented 6 years ago

When a FaceFX animation starts in negative time, the amount of negative time is truncated from the audio when the animation plays from sequencer (or matinee). So the result is that the audio is slightly clipped at the end during playback.

Normally the amount of negative time in an animation is small, so this can be difficult to detect, but in the attached file, Slade's welcome animation has been modified so that his head starts moving at around -3.0 seconds. Audio starts at time 0 (as always), so there is 3 seconds of head movement prior to the moving of the lips or playing audio. Because of the negative time, if you play this animation from sequencer, the audio chops off the last 3 seconds.

For the FBX and texture files see here, but be sure to use the .facefx and SladeFaceFX.ffxc folder from the attached:

SladeNegativeTimeKeys.zip

Happens when the animation is triggered from Sequencer & Matinee, but not Blueprint.

Happens in 4.19 & latest.

jcredmond commented 6 years ago

@dpakatheman close this out when you verify.

dpakatheman commented 6 years ago

I'm still getting the audio (and animation) clipped in my test case.

jcredmond commented 6 years ago

Confirmed fixed.

dpakatheman commented 6 years ago

New sequencer events are now created correctly, but due to #148 the old events will remain incorrect.