search

Facepunch / garrysmod-requests

Feature requests for Garry's Mod
86 stars 24 forks source link

Combine 64bit into all 32bit branches #2219

Open DarthTealc opened 1 year ago

DarthTealc commented 1 year ago
What: Combine 64bit and 32bit branches Why: To progress the 64bit rollout and CEF rollout. Also to move regular users off the 64bit development branch into a 'stable' branch where they'll get the normal release notes and server compatibility. How: Branch Description Corresponds with
public/main Contains both 32bit and 64bit - Updated when development is considered 'stable' current x86-64 branch but on a stable release cadence (every 6 or so months) for regular users
prerelease Contains both 32bit and 64bit, released for server/dev testing in advance of a stable release current prerelease branch but includes 64bit
dev Rolling development build for both 32bit and 64bit current x86-64 branch but for developers and testing

Users of the current x86-64 branch would move to dev if they're actually on it for testing, or they'd move to main if they just want to be using 64bit or CEF.

Awesomium would no longer exist under this structure as x86-64's 32bit executable (which would become main) uses CEF.

mcNuggets1 commented 1 year ago

Please.

MaslovKK commented 11 months ago

I think it's time to abandon x86 branch in favor to x86_64, because x86 OS has outlived itself.

DarthTealc commented 6 months ago

According to Steam Stats for April 2024, there is no need for the 32bit builds.

Windows: 99.92% of users are using 64bit. The rest are using 'other' which doesn't specify architecture. All supported versions of Windows (Win 10 and 11) have 64bit support. MacOS: Steam only supports 64bit and ARM versions of MacOS. These versions do not support 32bit applications. Linux: All listed versions are 64bit. Mostly Steam Deck which supports 64bit and Wine/Proton.

DarthTealc commented 5 months ago

According to Steam Stats for May 2024, 100.5% of Windows users are using 64bit (and 0.08% are using 'other' which doesn't specify architecture)

image

I'm no mathematician but if Valve says over 100% of Windows users are using 64bit, it's a good time to move Gmod across to x86-64.

DarthTealc commented 5 months ago

I've noticed people (kids?) on the Gmod discord complain about breaks on the x86-64 branch because they use it as a main stable (due to the inclusion of CEF and better performance) when it's not treated as such by developers. Having the main branch contain a stable 32 and 64bit version would resolve this. As mentioned in the original post, the dev branch would be the location for developers and testers as it would contain the development version in both 32 and 64bit.

Other than the difference between Awesomium (Chromium 17) and CEF (Chromium 88?) on 32/64, is there any disparity between functionality of 32/64 which would cause issues on a main branch?

DarthTealc commented 4 months ago

I've been made aware that CEF is included in the 32bit executables in the x86-64 branch, meaning we could get rid of Awesomium completely while still retaining 32bit support. I've updated the original post with this information and for better clarity.