search

Facepunch / sbox-issues

175 stars 12 forks source link

@import-ed SCSS in other SCSS files do not hotload #5317

Open MrBrax opened 7 months ago

MrBrax commented 7 months ago

Describe the bug

Simple, imported SCSS doesn't hotload when saving. The "master" SCSS file has to be saved for the child one to update.

To Reproduce

  1. Make two scss files
  2. @import the second one in the first
  3. Try hotloading the imported one

Expected behavior

To properly hotload imported ones

Media/Files

No response

Additional context

No response

MrBrax commented 3 months ago

https://github.com/user-attachments/assets/5efd8862-4297-4467-bdb0-8d8e91d4f77e

Issue shown in video

CarsonKompon commented 3 months ago

I had fixed this but it still wasn't working for relative paths. Should be all good now :)

MrBrax commented 3 months ago

nope still not working for me, i'm importing inside a stylesheet like @import "./shared.scss"; from a panel component with the stylesheet attribute

CarsonKompon commented 3 months ago

Yeah sorry about that I had to revert the changes because it broke something else. I'll need to take another look today :P

MrBrax commented 3 months ago

my sanity levels are already increasing, thanks much

Tankonyako commented 1 month ago

hot reloading of @imported scss are not working in PanelComponent, but in Panel all works fine

MrBrax commented 1 week ago

i'm also noticing some weird stuff going on with hotloading again

CarsonKompon commented 1 week ago

Yeah I believe this commit is what brought it back: Image