s&box editor preferences are not saving

Facepunch / sbox-issues

177 stars 12 forks source link

s&box editor preferences are not saving #5857

Closed matekdev closed 4 months ago

matekdev commented 4 months ago

Describe the bug

When I change my code editor to Visual Studio Code, it does not remember this option on the next launch of the s&box editor.

To Reproduce

Change editor settings to Visual Studio Code
Relaunch
Notice that it changed back to Visual Studio

Expected behavior

Media/Files

No response

Additional context

No response

dch-GH commented 4 months ago

I believe this is also happening to the Layout too. Layout is set to the default every time I open a project.

matekdev commented 4 months ago

Have the changes been pushed yet? I'm still encountering this.

Gmod4phun commented 4 months ago

Has been fixed since yesterday, at least for me. IDE stays the same, layout too

matekdev commented 4 months ago

Has been fixed since yesterday, at least for me. IDE stays the same, layout too

I launch up the s&box game editor
Click preferences, change it to Visual Studio Code
Close the entire editor
It does not save

I'm on staging and tested it this morning. Anyone else also experiencing this?

badandbest commented 4 months ago

I'm still experiencing this.

solwllms commented 4 months ago

@badandbest @matekdev The change is in yeah, must be something else going on here breaking it for you guys. I'll have another look to see if there's a different issue causing this I can repro.

Few things if you wouldn't mind:

I assume opening the solution does still open Visual Studio?
Anything in the log when reopening the editor? "X not found", "X not installed" etc
Is the "CodeEditor" setting being written properly to [steam path]\steamapps\common\sbox\config\tools.json? The value should be saved when you close the editor, does it get overwritten/reset at any point?

badandbest commented 4 months ago

I'll check these right now and get back to you

badandbest commented 4 months ago

When I change my preferences they only last for the current session.
Nothing in the logs I can find. But here it is anyway. Log.log
Notepad++ tells me tools.json is being modified by another program. But I was keeping my eye on the "CodeEditor" value and it never changed. Maybe this video tells you anything?

https://github.com/user-attachments/assets/baa5950f-dc1c-461a-ba64-9177b2afa69e

solwllms commented 4 months ago

Cheers for the info, looks like my cockup.

I've pushed a fix which should be live now if you can give this another whirl

badandbest commented 4 months ago

It works now. Thanks a million. This issue was bugging me a lot.

matekdev commented 4 months ago

thank you