search

FactbirdHQ / mqttrust

MQTT client for embedded devices, written in rust
50 stars 5 forks source link

Ownership-based approach #17

Closed keisrk closed 3 years ago

keisrk commented 3 years ago

Since read_with takes a while until getting released, here's a quick polyfill implementation.The idea is to simply use a struct which holds a buffer.

codecov-io commented 3 years ago

Codecov Report

Merging #17 (21248ef) into master (4c6c35e) will decrease coverage by 0.84%. The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #17      +/-   ##
==========================================
- Coverage   24.70%   23.85%   -0.85%     
==========================================
  Files           4        4              
  Lines         506      524      +18     
  Branches      149      152       +3     
==========================================
  Hits          125      125              
- Misses        302      320      +18     
  Partials       79       79
Impacted Files Coverage Δ
src/lib.rs 11.68% <0.00%> (-1.08%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4c6c35e...21248ef. Read the comment docs.

MathiasKoch commented 3 years ago

This could probably work as a temp solution until we land somewhere on https://github.com/rust-embedded-community/embedded-nal/issues/12

Could you rebase on master?

MathiasKoch commented 3 years ago

Could you also update it to make use of https://crates.io/crates/ublox-cellular-rs ?

keisrk commented 3 years ago

[This one](https://github.com/BlackbirdHQ/mqttrust/pull/18] supersedes.