search

Factual / drake

Data workflow tool, like a "Make for data"
Other
1.48k stars 110 forks source link

Add temporarily-unamed directive for including Drakefile and running … #193

Closed chen-factual closed 9 years ago

chen-factual commented 9 years ago

…contained steps from the directory of the included Drakefile. #184

Not ready for merge yet, just requesting comments.

@amalloy @dirtyvagabond

chen-factual commented 9 years ago

Addressed review comments and implemented directory switching for assigning shell variables.

chen-factual commented 9 years ago

Just so this doesn't lose momentum, what do you guys think is still needed to get this to be good enough to merge?

chen-factual commented 9 years ago

@amalloy Can we chat for 10 minutes about this today? I want to hash out the stuff about cljrows in person.

chen-factual commented 9 years ago

@amalloy Can you review the latest changes? This adds the warning we talked about for c4* protocols, and should make this feature merge-ready.

chen-factual commented 9 years ago

@amalloy Alright, so:

review comments: a458dec0a0b580ddb7146bc8e980c07cae1df608 fix for dumb bug: 7b447f37b96529004312a3241a7856693419d615 tests: ac0d9800f734ce244819054731fa59f812ba0295