Faileas / swloot

Automatically exported from code.google.com/p/swloot
0 stars 0 forks source link

Multiple rolls started simultaneously do not function properly #2

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Start a roll for one item ('roll [Broken I.W.I.N. Button'])
2. Before previous roll ends, begin a roll for a second item ('roll [Tear 
Stained Hankerchief]')

What is the expected output? What do you see instead?
The second roll should be ignored; instead the entire system fell apart 
and numbers were counted down in random order before the addon threw an 
error.

Original issue reported on code.google.com by dennis.z...@gmail.com on 7 Mar 2008 at 5:43

GoogleCodeExporter commented 9 years ago
A flag for a roll in progress or an roll identifier could be set to disallow or
differentiate multiple rolls.

Original comment by govtgeek on 10 Mar 2008 at 4:59

GoogleCodeExporter commented 9 years ago
I've actually added such a flag, but haven't tested it yet, since my working 
copy is 
currently pretty borked.  If somebody else doesn't beat me to it, I'll revert 
back 
to r5 and get it up before we finish Kara tonight.

Original comment by dennis.z...@gmail.com on 10 Mar 2008 at 10:44

GoogleCodeExporter commented 9 years ago
Uploaded a fix to this problem; rudimentary testing is promising.

Original comment by dennis.z...@gmail.com on 11 Mar 2008 at 1:44

GoogleCodeExporter commented 9 years ago

Original comment by dennis.z...@gmail.com on 11 Mar 2008 at 9:19

GoogleCodeExporter commented 9 years ago
[deleted comment]
GoogleCodeExporter commented 9 years ago
Not technically new, but the problem is not necessarily fixed.

Awarding an item during a roll will change the item rolled for to the one 
awarded.

I have not tested a roll start during one in progress.

Original comment by govtgeek on 26 Sep 2008 at 10:11