Enhancement: Inject services - Githubissues

FakerPHP / Faker

Faker is a PHP library that generates fake data for you

https://fakerphp.github.io

Other

3.57k stars 345 forks source link

Enhancement: Inject services #753

Closed localheinz closed 1 year ago

localheinz commented 1 year ago

What is the reason for this PR?

[x] injects services into extensions

Author's checklist

[x] Follow the Contribution Guide

Summary of changes

The idea here is to allow extensions to depend on other services, rather than depending on static methods from the Helper or similar.

This could allow for

centralizing (and reusing) the randomization aspect of fakerphp/faker
- selecting a random number
- selecting a random element from a list of elements
- shuffling a list of elements
extracting randomization strategies
- using mt_* functions
- using Random\Randomizer
- using a deterministic strategy in tests, for example)
letting extensions and extension packages focus on providing data

Review checklist

[x] All checks have passed
[ ] Changes are added to the CHANGELOG.md
[x] Changes are approved by maintainer

localheinz commented 1 year ago

Thank you, @bram-pkg!