FalsehoodMC / Fabrication

A huge collection of vanilla tweaks and small features for both Fabric and Forge.
https://www.curseforge.com/minecraft/mc-mods/fabrication
MIT License
114 stars 22 forks source link

Balance - Infinity and Tipped/Spectral Arrows #653

Open anoomolu opened 7 months ago

anoomolu commented 7 months ago

Hiya! Was wondering whether it'd be possible to add a tweak to the Infinity enchantment that reduces the chance of tipped arrows being consumed? Arrows of Harming now stack with the actual arrow damage thanks to the source-dependent I-frames tweak, so I thought it'd be nice to further encourage making tipped arrows in general.

Feel free to close this if feature requests aren't being accepted at this time.

lumagatto commented 7 months ago

I think Infinity should work like unbreaking for every arrow (1/(1+level) chance of using an arrow ). This would nerf infinity (needed) and make arrows useful again. This makes the most sense (it's also how hypixel skyblock did it). I agree with the intention of this feature suggestion but i think it should apply to all arrows

SFort commented 7 months ago

I think Infinity should work like unbreaking for every arrow (1/(1+level) chance of using an arrow ). This would nerf infinity (needed) and make arrows useful again. This makes the most sense (it's also how hypixel skyblock did it). I agree with the intention of this feature suggestion but i think it should apply to all arrows

i like this idea and it's what i'll be going with, will add a config to allow either though since tacking that on should be easy

peow commented 2 weeks ago

hello, i found a "simple" way to get the change in the infinity enchantment

I found this datapack https://modrinth.com/datapack/brunos-enchantments (with CC0-1.0 license) that uses this to make the change: image (split enchantment into 3 levels) image (configures the chance of the arrows being consumed)

https://github.com/BrunoGoldbergFerro/brunos-enchantments/blob/main/brunos-enchantments/data/minecraft/enchantment/infinity.json

the mod is only available for 1.21 unfortunately, I don't know if it's using datapack commands added only in this update

SFort commented 2 weeks ago

something was probably changed in 1.21. i recall trying to implement this and it being a client/server syncronization nightmare

peow commented 2 weeks ago

mmmm i see