search

FamousArchives / examples

[DEPRECATED]
214 stars 74 forks source link

Voice for examples #10

Closed dmvaldman closed 10 years ago

dmvaldman commented 10 years ago

@fettermania @michaelobriena @ftripier

Please consider these modifications.

In general: avoid pronouns like "you, we" Superlatives like "really" Adjectives like "great"

Prefix Surface, Modifier, etc with Famo.us Surface, Famo.us Modifier on first mention

See my TODOs

Touched: Core Haven't touched: Anything else

dmvaldman commented 10 years ago

please review pull request. we need to update to 0.0.5 and test

michaelobriena commented 10 years ago

I like all of the comment changes but have to disagree about the styling. I think that using the famous red and the famous fonts will be nicer than having straight red surfaces. @fettermania any opinion on simplicity vs style?

dmvaldman commented 10 years ago

I prefer the explicitness and simplicity. However, the surface example should have a class defined because it is illustrative. The font are preserved by having them inherit from body.

On Apr 5, 2014, at 11:43 AM, michaelobriena notifications@github.com wrote:

I like all of the comment changes but have to disagree about the styling. I think that using the famous red and the famous fonts will be nicer than having straight red surfaces. @fettermania any opinion on simplicity vs style?

— Reply to this email directly or view it on GitHub.

michaelobriena commented 10 years ago

I think this is really up to Tim, Shu, and Jeanne as it is more a marketing decision over a technical one. @timjchin @shupac please let me know your thoughts.

dmvaldman commented 10 years ago

Happy to defer to the creative and marketing team for how our examples should look. I would just caution against too much mystery CSS if it's hidden from the viewer.