search

FamousArchives / examples

[DEPRECATED]
214 stars 74 forks source link

update git modules to point to http instead of git #29

Closed MylesBorins closed 10 years ago

MylesBorins commented 10 years ago

This solves #28 and #25 more elegantly

I also think it might be worth switching this repo over to the new project formate... it would be possible to make a grunt task to automate switching between examples.

jedihe commented 10 years ago

I remember testing in my fork doing that... but when checking out the internal submodules, I had the same issue: "Permission denied (publickey)". So, this change should be done in the famous repo too.

Are you able to test both the wrong and fixed states?

MylesBorins commented 10 years ago

@jedihe You are totally right! Sorry I glazed over that. I ended up changing the version of famous that things are being pointed to. It now points at the flattened branch, which should solve this entire problem

dmvaldman commented 10 years ago

Can we have the src/famous track master?

MylesBorins commented 10 years ago

Yup, we just need to make sure it is pointing to httpnot git On Apr 27, 2014 5:25 PM, "David Valdman" notifications@github.com wrote:

Can we have the src/famous track master?

— Reply to this email directly or view it on GitHubhttps://github.com/Famous/examples/pull/29#issuecomment-41514500 .

MylesBorins commented 10 years ago

And also make sure it is pointing to the commit with httpin the main repo git modules On Apr 27, 2014 5:26 PM, "Myles Borins" myles@famo.us wrote:

Yup, we just need to make sure it is pointing to httpnot git On Apr 27, 2014 5:25 PM, "David Valdman" notifications@github.com wrote:

Can we have the src/famous track master?

— Reply to this email directly or view it on GitHubhttps://github.com/Famous/examples/pull/29#issuecomment-41514500 .

MylesBorins commented 10 years ago

Closing and going to make a new pull request