search

Farama-Foundation / Arcade-Learning-Environment

The Arcade Learning Environment (ALE) -- a platform for AI research.
GNU General Public License v2.0
2.11k stars 418 forks source link

ROM file not found on `ale_py 0.9.0`. Should the docs example be changed? #538

Closed floringogianu closed 2 weeks ago

floringogianu commented 3 weeks ago

Installed ale_py with pip install ale_py in a conda environment. The following snippet crashes with ROM file XXX not found for any game:

from ale_py import ALEInterface

ale = ALEInterface()
ale.loadROM("Pong")

What works instead is importing roms and using the get_rom_path utility:

from ale_py import ALEInterface, roms

ale = ALEInterface()
ale.loadROM(roms.get_rom_path("pong"))
pseudo-rnd-thoughts commented 3 weeks ago

Thanks for the issue, @jjshoots is there a nice solution to this where we don't need to change the example?

jjshoots commented 3 weeks ago

Interesting... I think during the past update, we moved the location where all the roms were to another place, and an underlying binding didn't get the memo. I think it wouldn't be too hard to fix the C API. I can get to it tomorrow.

pseudo-rnd-thoughts commented 2 weeks ago

@jjshoots or @floringogianu Could you make a PR to update the documentation

jjshoots commented 2 weeks ago

Sure.