Farama-Foundation / Metaworld

Collections of robotics environments geared towards benchmarking multi-task and meta reinforcement learning
https://metaworld.farama.org/
MIT License
1.28k stars 274 forks source link

Fixing missing number of steps check #435

Closed reginald-mclean closed 1 year ago

reginald-mclean commented 1 year ago

In the original repo, the do_simulation function in the modified mujoco env had a check for the maximum number of steps per env. This was added back in now that Meta-World uses the Mujoco Env in Gymnasium

reginald-mclean commented 1 year ago

@pseudo-rnd-thoughts actually, do you have any thoughts about removing this value error and returning truncated=True? That way we don't need to wrap any Meta-World environment in a TimeLimit wrapper or keep track of the number of steps.

pseudo-rnd-thoughts commented 1 year ago

I'm a bit confused on the structure of the metaworld environments, is there a technical description anywhere?

reginald-mclean commented 1 year ago

I copied the code that got removed from the modified MuJoco env to the Sawyer base class. We can remove this value error if we set truncated=True when the max number of steps has been hit? Unfortunately I don't think there's any great documentation on the environments themselves

reginald-mclean commented 1 year ago

@pseudo-rnd-thoughts I removed the use of getattr