FashionFreedom / Seamly2D

Open source patternmaking software to democratize fashion.
https://seamly.io
GNU General Public License v3.0
616 stars 111 forks source link

fix: switch formula length and angle order in property editor for interactive curve #1106

Closed DSCaskey closed 6 months ago

DSCaskey commented 6 months ago

This switches the order of the length and angle formula fields for the Curve - Interactive tool in the Property Editor so it matches the order in the dialog.

image

image

Fixes issue #1105

what-the-diff[bot] commented 6 months ago

PR Summary 📑

Your work is going to get more exciting and effortless with these enhancements! Your creativity is no longer restricted by limitations; instead, it is boosted by possibilities and precision! Let's keep innovating, together! 👏💼

DSCaskey commented 6 months ago

Hey @csett86,

Somehow we inadvertantly enabled that commits need to be signed, and currently my git client is not setup to sign commits, so Susan turned it off for now. I'll play around with the commit signing on my fork, and we can look at enabling it again in the future. In the mean time I'll probably delete this PR and just submit a new one, as apparently once you make an unsigned commit the only way to fix it is to rebase and force the commit.

csett86 commented 6 months ago

Hi @DSCaskey dont delete this PR, I will disable the windows signing (due to the expired certificate) and then this PR is good to go

DSCaskey commented 6 months ago

Hey @csett86,

Ah... Got it. Now that the commit signing is off the PR is still good.

Thanks.

On Wed, May 8, 2024, 1:40 AM Christoph Settgast @.***> wrote:

Hi @DSCaskey https://github.com/DSCaskey dont delete this PR, I will disable the windows signing (due to the expired certificate) and then this PR is good to go

— Reply to this email directly, view it on GitHub https://github.com/FashionFreedom/Seamly2D/pull/1106#issuecomment-2099780627, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHTXADRTORBJ4CLYVM42FI3ZBG3ETAVCNFSM6AAAAABHH6ROWOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJZG44DANRSG4 . You are receiving this because you were mentioned.Message ID: @.***>