FashionFreedom / Seamly2D

Open source patternmaking software to democratize fashion.
https://seamly.io
GNU General Public License v3.0
616 stars 111 forks source link

BUG: Linetype and lineweight pen presets are not working with every tool #1131

Closed Onetchou closed 4 months ago

Onetchou commented 5 months ago

Some tools such as the "on bissector" or "on perpendicular" are not using the pen preset for lineweight or linetype.

image

Onetchou commented 5 months ago

I checked for the "On Perpendicular" tool, and It's because of these lines at the end of the constructor:

// Call after initialization vis!!!!
    setLineType(LineTypeDashLine);
    setLineWeight("0.35");

Link to the lines in the code

@DSCaskey do you maybe remember why these lines have been added? 😊

Onetchou commented 5 months ago

I think this behavior has been added because the perpendicular lines are very likely to be "construction lines" so it's kind of using a default "construction" pen preset.

But I personally think that it is misleading to overwrite the pen preset for this particular reason : if the user wants a pen style more suitable for a construction line he always has the possibility to do it manually.

I personally draft patterns without tracing any line at all, I then add the visible pattern lines using the line tool, and I find quite annoying the fact that I have to manually change the style of those lines thare are not following the pen preset.

Onetchou commented 4 months ago

I created a thread on the forum to discuss this pen preset behavior, so we can collect the opinion of the users: there.

😊