Image origin tool

[Onetchou]

Fixes #1099

It's now possible to change the origin point of images.

Right click on an image -> change origin:

Click on the new origin point:

The (x,y) position of the image is now the position of this point:

And the image is rotated around this point:

[what-the-diff[bot]]

PR Summary

Hello there! Our developer team is on fire! 🚀 Here's what we've been doing to improve the project:

• New cursor image addition 😍:
  We've added a cool new icon (named "image_origin_cursor.png") in the "cursor.qrc" file for our interface.

• Introduction of 'Change Origin' Action 💡:
  We've whipped up a convenient new menu action called "Change Origin". This gives you the opportunity to easily change the starting point of an image in our project! Makes things much simpler, doesn't it?

• Introduction of 'm_selectNewOrigin' variable 📝:
  As part of creating the new Change Origin feature, we've added an 'm_selectNewOrigin' variable to the ImageItem class. This would help us determine and handle the new starting point of an image item.

• Function modification for better functionality 🛠️:
  We've updated several functions (e.g., setOrigin, paint, hoverEnterEvent etc.) within the "ImageItem" class to make the Change Origin feature as smooth as possible. This ranges from showing the new cursor, drawing a blue line to indicate the image's origin, handling clicks and releases, and managing an escape key press to abort the operation! Now, every click, hover, and key press is going to feel much more responsive!

• UI updates post-resizing 🔄:
  The 'updateFromHandles' function has been altered to smartly update an image's origin once you're done resizing it.

• The boost to our constants ✨:
  Lastly, we also added a new constant in the "def.cpp" and "def.h" files that lets us easily refer to the path of our new cursor image.

Such exciting times! Can't wait for you to try out these changes! Stay tuned for more enhancements coming your way! 😄

[Onetchou]

Mmmmm don't know exactly what I touched that could cause this fail in the SeamlyMe tests:

[DSCaskey]

Mmmmm don't know exactly what I touched that could cause this fail in the SeamlyMe tests:

I'm not sure either. I got the similar error with a previous PR... and I'm sure it's the same thing with a PR I just made. Something seems to have changed somewhere as some of the test measurement files seem to be missing? I'll need to dig into the test and commit history to see what's missing or not getting copied.

[DSCaskey]

It's got to be an issue in the ci.

I just ran the collection test locally and the tests pass... after moving the test/collectiontest/bin folders & test to seamly2D/bin. The test needs some qt libs & the platforms folder

[DSCaskey]

The test run is giving this warning:

Looking up the warning I found this:

and the script is using:

Could this explain why the tests work sometimes and fail other times?

[DSCaskey]

Hey @Onetchou... I merged develop in to fix the tests. Once you make the requested change I'll approve & merge. :)

[Onetchou]

@DSCaskey

It's one of those semantic things. While setting the origin is changing the origin, changing the origin doesn't neccessarily mean you're setting the origin... you could be changing the origin transform, but not setting the origin.

I was about to make the change, but I'm puzzled... Doesn't "setting the origin" implies that there was no origin before? Because the tool is only moving the origin, changing its position, the origin was there before, at the top left of the image... Same for "select the origin", it would imply that the origin was not selected before, but it was already there.

What do you think?

[DSCaskey]

I was about to make the change, but I'm puzzled... Doesn't "setting the origin" implies that there was no origin before? Because the tool is only moving the origin, changing its position, the origin was there before, at the top left of the image... Same for "select the origin", it would imply that the origin was not selected before, but it was already there.

What do you think?

Actually as I think about it more... just to throw you a curve, Technically "Move origin" is a more asccurate descriptor. :) Again "Change" leaves me with "change from what"? "Select" makes sense in that it tells a user they have to select a point, as well as it matches the existing code routine names.

I think I like "Move origin"... it implies an origin exists and that it's moving - ie changing. :)

[DSCaskey]

@Onetchou

I know what I don't like about "Change origin"... we're not changing the origin as it implies... we're changing the origin's position, where "Change origin position" is too long. IMO "Move origin" conveys the same meaning more concisely. :)

[Onetchou]

@Onetchou

I know what I don't like about "Change origin"... we're not changing the origin as it implies... we're changing the origin's position, where "Change origin position" is too long. IMO "Move origin" conveys the same meaning more concisely. :)

Deal! 😆 I'll change it to "Move origin"