search

FasterXML / jackson-databind

General data-binding package for Jackson (2.x): works on streaming API (core) implementation(s)
Apache License 2.0
3.53k stars 1.39k forks source link

Badoken/global enum naming strategy #4723

Closed badoken closed 1 month ago

badoken commented 2 months ago

Fixes/implements #4674 Replaces #4716

cowtowncoder commented 1 month ago

I think I am happy with this PR (although slightly worried wrt merging it to main/3.0 but that's not something that can be avoided here). But one last thing before merging: unless we have asked for and received it, we'll need CLA from here:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

This only needs to be done once, and is good for all future PRs. The usual way is to print it, fill & sign, scan/photo, email to cla at fasterxml dot com. Once this is done, I'll go ahead and merge pr.

Thank you again for this contribution @badoken !

badoken commented 1 month ago

Hey @cowtowncoder Thank you, I'm glad to help I've just sent the CLA to the email address, please let me know if all is good

cowtowncoder commented 1 month ago

CLA received, can proceed!