search

FasterXML / jackson-datatype-joda

Extension module to properly support full datatype set of Joda datetime library
Apache License 2.0
140 stars 82 forks source link

JacksonJodaDateFormat, JacksonJodaFormatBase, JacksonJodaPeriodFormat needs some constructor Refactoring #85

Closed joxerTMD closed 8 years ago

joxerTMD commented 8 years ago

In order to implement https://github.com/FasterXML/jackson-annotations/issues/95 for Joda module i suggest to add new constructor for these classes that accepts the state of formatter. We need this because the current possibility to add new factory methods is limited by constructor's signature. i.e We can't now have two factory methods of formatter like these: JacksonJodaDateFormat.withSomething(Boolean property).

joxerTMD commented 8 years ago

As soon as it's done we can easily implement https://github.com/FasterXML/jackson-annotations/issues/95 like this https://github.com/joxerTMD/jackson-datatype-joda/pull/1

cowtowncoder commented 8 years ago

Sounds reasonable. One thing I need at this point (unless it's already done -- apologies if so) is the Contributor License Agreement, from here:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

which we need to get just once and is good for all Jackson projects. Easiest way is usually to print it, fill & sign, scan and email to info at fasterxml dot com.

Looking forward to merging these patches, thank you in advance!

joxerTMD commented 8 years ago

the link above returns 404 error for me :(

cowtowncoder commented 8 years ago

@joschi ah sorry, wrong link. Updated -- I have a copy of CLA in multiple repose, put wrong link.

joxerTMD commented 8 years ago

Done. CLA is signed and sent