search

Fbada006 / ArtMaker

ArtMaker is a flexible and customisable library that allows users to draw anything they want on screen and has been built fully with Jetpack Compose.
75 stars 3 forks source link

Hook Up Stroke Width with Controller #34

Closed emmanuelmuturia closed 4 months ago

emmanuelmuturia commented 4 months ago

closes #29

Fbada006 commented 4 months ago

This is a good attempt but there are a few issues here that need to be addressed:

  1. There is no need to have the slider pop up as a dialog. Use inspiration from this library if necessary: https://github.com/akshay2211/DrawBox. But place the slider above the control menu instead of below it. Clone and run the app from that repo and you will see what I mean.
  2. The slide width should be working with the actual drawing, not simply creating the UI. Ask for help if necessary on this.
  3. All the components that you add need to be aesthetically pleasing. Ask yourself the question: is what I am creating aesthetically pleasing? If I find this in app, would I like it?
emmanuelmuturia commented 4 months ago

@CalebKL This is noted. Please disregard my latest push as I was backing up my local changes...

emmanuelmuturia commented 4 months ago

@CalebKL Could you please try and run DrawBox (https://github.com/akshay2211/DrawBox) on your end? I am encountering some weird Gradle error where the drawBox module is not being recognised. I have also asked @Fbada006 to do the same so that I can confirm if this is a localised issue or not...

CalebKL commented 4 months ago

@CalebKL Could you please try and run DrawBox (https://github.com/akshay2211/DrawBox) on your end? I am encountering some weird Gradle error where the drawBox module is not being recognised. I have also asked @Fbada006 to do the same so that I can confirm if this is a localised issue or not...

Update Gradle to 8.5

emmanuelmuturia commented 4 months ago

@CalebKL I see that it works when I upgrade the Gradle version on MacOS but not on my laptop. I think I might have missed something else and thus I will check and report to you in the evening. In the meantime let me work on the changes and push them as requested by @Fbada006 and yourself...

emmanuelmuturia commented 4 months ago

@CalebKL @Fbada006 Please disregard my latest changes again...