Closed forteller closed 3 months ago
pavinjosdev
commented
4 months ago Hi there 👋
The extension currently parses keywords from this file in addition to automated keyword parsing from the Unicode standard, you can add your keywords to the respective emoji codepoints in this file.
It should be a fairly easy PR as it's just a JSON file 🍃
forteller
commented
4 months ago Thanks! I see that it's already there. But also, if I understand correctly, the file hasn't been changed in three months? So I guess the extension just needs to be updated with the latest version of the file? I don't know much about these things.
I also noticed, though, that the trans flag has the keywords "nonbinary" and "nb" attached to it. I feel that is not ideal, seeing as nb is not the same as trans, and nb has their own flag. Maybe not a unicode emoji flag, but still. I think those keywords should be removed. I could try to do a PR for it myself, but I've never done any PR before, so I'd have to figure out how 😅
FelipeFTN
commented
4 months ago Hello folks! How are you?
Yeah, we should take a little update on our keywords hahaha :sweat_smile: I was already planning to do some upgrades on the emoji search bar.
@pavinjosdev I'm not sure if the emoji_map.json file is working properly. I'm typing nonbinary for example, and the search is not finding the emoji with that keyword. Also, searching for ufo for the :alien: alien emoji is not returning anything...
@forteller, as for the pull request, don't worry, I can make the proper changes here, Emoji Copy is quite a few time without many updates :sweat_smile: So I will take this opportunity to actually work on some stuff! :tada:
:memo: Can you guys also test and tell me, if words like "ufo", "nonbinary", "weak"... is returning any emojis to you? Here, I'm not getting any results from the search, even though we have these keywords in the emoji_map.json file. :thinking:
forteller
commented
4 months ago Thank you! :)
No, I don't get any results on any of those
FelipeFTN
commented
4 months ago @pavinjosdev Buddy, do you have any favorite messaging app, like element, or email for example? :mailbox:
I need your help with some discussions about the emoji_map file hahaha Can we use some app to communicate better?
I like using Matrix Element. Here's my profile, please, send me a message https://matrix.to/#/@felipeftn:matrix.org :rocket:
Also, here is my email, if you prefer: felipeftn@protonmail.com
I'm thinking about reworking a bit the emoji_map.json file, but since it have 7828 lines, I think is pretty dangerous hahaha and might be a better approach for what I want to do.
FelipeFTN
commented
3 months ago @pavinjosdev made an amazing job solving, this issue! This should be working great now!! :100:
Also, a little bug in parser.py was found. This was causing some keywords in the emoji_map.json file not to work properly.
Now, it's just fine. Also, you can easily add more keywords and submit a new Pull Request if you wish! Feel free to explore the code and make your changes! @forteller
The issue looks solved, so I'll be closing it for now! :tada:
forteller
commented
1 month ago I also noticed, though, that the trans flag has the keywords "nonbinary" and "nb" attached to it. I feel that is not ideal, seeing as nb is not the same as trans, and nb has their own flag. Maybe not a unicode emoji flag, but still. I think those keywords should be removed.
Hi again. I'm really happy this issue got solved! But the problem that I pointed out in the quote above did sneak in. Would this be possible to change? Thanks!
Hi. Thanks for a great extension!
Would it be possible to have the rainbow flag show up if you search for "pride" also, in addition to "rainbow flag"? Thanks!