search

FelixSchwarz / mjml-python

Python implementation for MJML - a framework that makes responsive-email easy
MIT License
72 stars 16 forks source link

Add support for custom components #30

Closed caseyjhol closed 1 year ago

caseyjhol commented 1 year ago

Closes #29.

@FelixSchwarz You might consider this a rough draft, but it seems like it's working as expected. The test components could probably be more complex. Let me know what you think.

Components now support a component_name property (the majority of the file changes are just adding this one line).

caseyjhol commented 1 year ago

@FelixSchwarz Updated - much cleaner now.

caseyjhol commented 1 year ago

@FelixSchwarz I think I've addressed all of your requested changes. Let me know if I missed anything.

FelixSchwarz commented 1 year ago

Can only say sorry again for letting you waiting so long. I updated the main branch, fixing the test suite (missing_ok, but also different image so we can have tests for Python 3.6) so unfortunately there is now a conflict.

Is it ok if I resolve that manually + squash your commits into a single one for merging?

caseyjhol commented 1 year ago

No worries. Sure thing - go ahead and resolve/squash. I think you should be able to commit to my branch. Let me know if not and I can address.

FelixSchwarz commented 1 year ago

I merged this manually (after fixing an import problem with the custom component test) as 4ce237628dbb9a8877add8e780b094e483f47cfc

Thank you very much for your work + persistence.