search

Fermium / datalogger

The Datalogger physicists deserve
0 stars 0 forks source link

move hall-specific usb code to datachan #91

Closed ddavidebor closed 6 years ago

ddavidebor commented 7 years ago

hall-specific usb code MUST be moved to data-chan-nodejs, as we did for python. It's completely unmanageable inside datalogger.

In data-chan-nodejs we have a coherent way of keeping track of versions in the repository, writing tests, writing documentation...

ddavidebor commented 7 years ago

example https://github.com/fermiumlabs/data-chan-python

https://github.com/fermiumlabs/data-chan-python/blob/master/data_chan/instruments/fermiumlabs_labtrek_jv/hall_effect_apparatus.py

Similarly, a submodule for the instrument (possibly with a similar path to the one in the python implementation) should be made in data-chan-nodejs

The functions, if they have different names, should be renamed following the python implementation.

more or less the two libraries should be identical

ddavidebor commented 7 years ago

@wtubog i've done some works in bortoworks. now the code should be readable

ddavidebor commented 7 years ago

but now i realize usb.js is specific to only one instrument in the current state... Well, we're going to need to move the code away anyway, but sooner or later there's going to be some refactoring of usb.js

ddavidebor commented 7 years ago

i should probably get started with this

SimoneTosato commented 6 years ago

Solved. Now usb.js is a specific file in every device src folder