Feu-Secret / Tokenmagic

A Foundry VTT module that allows you to add animations and graphic effects to tokens, tiles, templates and drawings.
GNU General Public License v3.0
52 stars 36 forks source link

Covenient Effects is Adding Multiple of the Same Custom Active Effect #276

Closed Shareenx closed 1 month ago

Shareenx commented 1 month ago

Module Version: 7.1.1 Foundry Version: 12.331 Game System D&D 5E Version 4.0.4 Effects Panel Version: 4.02 Browser: Chrome Version 129.0.6668.100 (Official Build) (64-bit) Other Modules Active: None

Before open any issue 1) Enable the module setting "Enable debugging" (There is no module setting in the UI to enable debugging) 2) Click F12 go to the console tab 3) make the test you want and replicate the error 4) Go to the tab console open on point 2) and just right click and click 'Save as' and 'Save' or send a screenshot of the exception on the console. 5) Attach the text file on the github issue with all the logs related tot he module, or send a screenshot of the messages on the console.

Describe the bug This has been going on for a long time. I had hoped updating to v12, and updating everything would make it go away. Alas, it is still here.

When a PC Actor (Does not seem to occur for NPC's), multiple custom Active Effects are applied. Just this one, though. "Hurt" (I have multiple custom effects) At one point I had DAE, Combat Utility Belt, Active Token Effects some or all going (testing and playing with modules). I am trying to find where DFred's Convenient Effects reads from to apply the Effects Automatically so I can go in and try to make it stop the multiple applications.

To Reproduce Steps to reproduce the behavior:

  1. Have a Custom Active Effect "Hurt" 0a. At some point, set it in a module somewhere so that it would trigger on HP < 0, to stack multiples. 0b. Go through Module, Foundry, Gaming System updates 0c. Everything is fine, do 0b several more times. 0d. One day-
  2. Open a PC Character Sheet
  3. Click on the Current HP
  4. Type "-5" (or adjust manually to some number lower than the max)
  5. See error

Expected behavior Just one instance of the custom Active Effect "Hurt" to be applied.

Screenshots If applicable, add screenshots to help explain your problem. See below

Additional context I am certain some other module made some change to a config file flagging which Active Effects automatically should be applied. At one point I had DAE, Combat Utility Belt, Active Token Effects some or all going (testing and playing with modules). However, those modules either are deprecated, do not work, uninstalled, or inactive. Dfred's is the module applying the Active Effect automatically, so just would like to know where it is reading that config.

Attachment Descriptions Set HP to 40/ 45 Add_Hurt.log

Add_Hurt

Clear log, set HP back to max Heal_Up.log

Heal_Up

Set name of the Active Effect to something else, Apply damage (Set HP to 40/45) Hurt_Effect_Missing.log

Pictures of the Active Effect Card

Hurt1 Hurt2 Hurt3 Hurt4
Shareenx commented 1 month ago

I am a goober. Smoking something, because this belongs in dFred's and I just noticed. Derp, sorry