FilledStacks / stacked-mobile-starter

A mobile app starter template that's generated from the stacked-cli as a starter project
10 stars 0 forks source link

Initial Feedback on starter template #16

Open FilledStacks opened 1 month ago

FilledStacks commented 1 month ago

Hey,

I couldn't run the app.

Localisation broke everything for me, so first thing is to remove that and get a working version of the build pushed.

You can hardcode the text strings for now or use a string_constants.dart file and store it all in there, but hard coding is fine. This is a starter template, so most likely all the UI will be changed.

Below are more details about the issues, please let me know when it works.

Issues

  1. flutter pub get fails. Flutter version 3.22.2
    Pub get failure ``` Note: intl is pinned to version 0.19.0 by flutter_localizations from the flutter SDK. See https://dart.dev/go/sdk-version-pinning for details.

Because stacked_mobile_starter depends on flutter_localizations from sdk which depends on intl 0.19.0, intl 0.19.0 is required. So, because stacked_mobile_starter depends on intl ^0.18.1, version solving failed.

You can try the following suggestion to make the pubspec resolve:

  1. Localisation is not required as apart of the template. I do not like the way normal Flutter forces you to implement localisation and it's not the way I want to recommend Stacked developers do it. Please remove that piece, developers can implement localisation how they see fit.

  2. Localisation is breaking, I can't get it working.

The following compile error is everywhere:

Undefined name `S`

I ran dart run build_runner build --delete-conflicting-outputs and nothing improves.

Also the following import is not available:

import 'package:stacked_mobile_starter/generated/l10n.dart';
moak13 commented 1 month ago

All feedback was well received. I will proceed as instructed.

moak13 commented 1 month ago

Hi @FilledStacks, kindly find the fix to your issue on this PR. Thanks for the suggestion.