Financial-Times / ft-origami

The Old Origami Website, do not use
https://github.com/Financial-Times/origami
76 stars 12 forks source link

Installation instructions are wrong #585

Closed leggsimon closed 6 years ago

leggsimon commented 6 years ago

Following a fresh clone, make install fails with

➜  ft-origami git:(gh-pages) make install
Makefile:6: node_modules/@financial-times/origami-service-makefile/index.mk: No such file or directory
make: *** No rule to make target `node_modules/@financial-times/origami-service-makefile/index.mk'.  Stop.

This is due to the fact that the Makefile immediately expects there to be a node_modules directory (lol)

https://github.com/Financial-Times/ft-origami/blob/e6682e09d923394f93eec8cae0a133ef041bcda0/Makefile#L1-L8

Not sure what the preference would be your end. Update docs? Change the Makefile? Whatevs