FineUploader / fine-uploader-wrappers

ES6 classes that wrap a Fine Uploader S3, Azure, or Traditional instance & provide additional features.
MIT License
28 stars 12 forks source link

Use a polyfill for WeakMap for older browsers #1

Closed Elhebert closed 7 years ago

Elhebert commented 7 years ago

Currently writing my unit tests, and came accros an issue with callback-proxy.js.

PhantomJS 2.1.1 (Mac OS X 0.0.0) ERROR
  ReferenceError: Can't find variable: WeakMap
  at webpack:///~/fine-uploader-wrappers/callback-proxy.js:19:0 <- index.js:27812

I know it's not an issue per se, because PhantomJS don't know WeakMap (I'm currently looking for a polyfill), but since fine-uploader is supposed to be compatible with IE8+, it might be a good idea to add a polyfill when it's not available for a given browser.

rnicholus commented 7 years ago

A couple things:

I stopped using phantom a long time ago, it's too much of a hassle. Better to test against real browsers anyway.

Time to move forward and leave old browsers behind!