search

FiniteVolumeTransportPhenomena / PyFVTool

Finite volume toolbox in Python
GNU Lesser General Public License v2.1
13 stars 4 forks source link

Pull in contributions by gmweir #26

Closed mhvwerts closed 8 months ago

mhvwerts commented 9 months ago

I found a PyFVTool fork by @gmweir (https://github.com/gmweir/PyFVTool/tree/develop) from which I was able to git cherry-pick most of the commits, resolve some conflicts and adapt them to the current version of PyFVTool.

The commits in this PR consist of some new Notebooks, based on stuff from the Matlab PVTool, a few docstrings, and two utility functions (cellLocations and faceLocations). There are no changes to the core code.

I did not look at everything in great detail, but all Notebooks pass pytest, and the other tests scripts work fine, so I think that these contributions can be safely integrated in the main branch and work can continue from there.

mhvwerts commented 8 months ago

Indeed, I was wondering too. With every commit to the main branch it would become more difficult to merge in these nice contributions, so I felt like pulling them in before they would get lost. In addition, they increase test coverage. For me, it was a nice opportunity to discover cherry picking and conflict resolution with git, as a short break from administrative duties in real life.

gmweir commented 8 months ago

Thank you for merging in what I had, and reminding me about this project

I will pull in the new commits from the main branch and get back to this project in the winter.

mhvwerts commented 8 months ago

Great to hear this, @gmweir! Thanks for the nice contributions and looking forward to any future work.