Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk
Apache License 2.0
63 stars 30 forks source link

fix: Use bytes instead of string comparison in delete validator queue (backport cosmos/cosmos-sdk#12303) #1301

Closed 0Tech closed 4 months ago

0Tech commented 4 months ago

Description

Cherry-pick of:

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

CLAassistant commented 4 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: 0Tech
:x: williamchong
You have signed the CLA already but the status is still pending? Let us recheck it.

0Tech commented 4 months ago

Please ignore CLA.

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 70.43%. Comparing base (a7a39e5) to head (29cc88d).

:exclamation: Current head 29cc88d differs from pull request most recent head b16ba19. Consider uploading reports for the commit b16ba19 to get more accurate results

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1301/graphs/tree.svg?width=650&height=150&src=pr&token=m16qfzIPO7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) ```diff @@ Coverage Diff @@ ## main #1301 +/- ## ========================================== - Coverage 70.43% 70.43% -0.01% ========================================== Files 643 643 Lines 54724 54726 +2 ========================================== Hits 38544 38544 - Misses 14009 14010 +1 - Partials 2171 2172 +1 ``` | [Files](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1301?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) | Coverage Δ | | |---|---|---| | [x/staking/keeper/validator.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1301?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9zdGFraW5nL2tlZXBlci92YWxpZGF0b3IuZ28=) | `80.95% <50.00%> (-1.27%)` | :arrow_down: | ... and [3 files with indirect coverage changes](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1301/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)
0Tech commented 4 months ago

Please ignore coverage on panic scenarios.