Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk
Apache License 2.0
62 stars 29 forks source link

fix: ignore error when key not found in keys delete #1312

Closed 170210 closed 6 months ago

170210 commented 6 months ago

Description

If you provide a list of keys to the keys delete command, it will stop and fail if one of those keys is not found.

This pr cherry-pick the following pr:

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

CLAassistant commented 6 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: 170210
:x: JulianToledano
You have signed the CLA already but the status is still pending? Let us recheck it.

codecov[bot] commented 6 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 70.41%. Comparing base (05ff4ea) to head (495b1f8).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1312/graphs/tree.svg?width=650&height=150&src=pr&token=m16qfzIPO7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) ```diff @@ Coverage Diff @@ ## main #1312 +/- ## ========================================== - Coverage 70.41% 70.41% -0.01% ========================================== Files 643 643 Lines 54758 54759 +1 ========================================== Hits 38560 38560 - Misses 14023 14024 +1 Partials 2175 2175 ``` | [Files](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1312?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) | Coverage Δ | | |---|---|---| | [client/keys/delete.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1312?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-Y2xpZW50L2tleXMvZGVsZXRlLmdv) | `74.28% <100.00%> (+0.75%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1312/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)