Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk
Apache License 2.0
63 stars 30 forks source link

fix: update param validation to fail on nil dec #1323

Closed jaeseung-bae closed 4 months ago

jaeseung-bae commented 4 months ago

Description

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 70.38%. Comparing base (c051dcc) to head (1dba6ec).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1323/graphs/tree.svg?width=650&height=150&src=pr&token=m16qfzIPO7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1323?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) ```diff @@ Coverage Diff @@ ## main #1323 +/- ## ========================================== - Coverage 70.39% 70.38% -0.02% ========================================== Files 643 643 Lines 54779 54793 +14 ========================================== + Hits 38563 38564 +1 - Misses 14041 14054 +13 Partials 2175 2175 ``` | [Files](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1323?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) | Coverage Δ | | |---|---|---| | [x/slashing/types/params.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1323?src=pr&el=tree&filepath=x%2Fslashing%2Ftypes%2Fparams.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9zbGFzaGluZy90eXBlcy9wYXJhbXMuZ28=) | `0.00% <0.00%> (ø)` | | | [x/mint/types/params.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1323?src=pr&el=tree&filepath=x%2Fmint%2Ftypes%2Fparams.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9taW50L3R5cGVzL3BhcmFtcy5nbw==) | `7.40% <0.00%> (-0.60%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1323/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)
170210 commented 4 months ago

~Is it necessary to add the same contents under x/distribution? There are three similar bugs under x/distribution.~

jaeseung-bae commented 4 months ago

Is it necessary to add the same contents under x/distribution? There are three similar bugs under x/distribution.

I can't find any in x/distribution, could you share the points?

170210 commented 4 months ago

I can't find any in x/distribution, could you share the points?

Sorry, I made a mistake. There's no problem under x/distribution...