Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk
Apache License 2.0
62 stars 29 forks source link

feat: fbridge transfer #1347

Closed tkxkd0159 closed 2 months ago

tkxkd0159 commented 2 months ago

Description

closes: #XXXX

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 43.68932% with 58 lines in your changes are missing coverage. Please review.

:exclamation: No coverage uploaded for pull request base (pjdp1@82e8936). Click here to learn what that means.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1347/graphs/tree.svg?width=650&height=150&src=pr&token=m16qfzIPO7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1347?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) ```diff @@ Coverage Diff @@ ## pjdp1 #1347 +/- ## ======================================== Coverage ? 70.24% ======================================== Files ? 662 Lines ? 55120 Branches ? 0 ======================================== Hits ? 38719 Misses ? 14210 Partials ? 2191 ``` | [Files](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1347?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) | Coverage Δ | | |---|---|---| | [simapp/app.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1347?src=pr&el=tree&filepath=simapp%2Fapp.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-c2ltYXBwL2FwcC5nbw==) | `80.06% <100.00%> (ø)` | | | [x/fbridge/keeper/genesis.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1347?src=pr&el=tree&filepath=x%2Ffbridge%2Fkeeper%2Fgenesis.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mYnJpZGdlL2tlZXBlci9nZW5lc2lzLmdv) | `0.00% <0.00%> (ø)` | | | [x/fbridge/keeper/grpc\_query.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1347?src=pr&el=tree&filepath=x%2Ffbridge%2Fkeeper%2Fgrpc_query.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mYnJpZGdlL2tlZXBlci9ncnBjX3F1ZXJ5Lmdv) | `0.00% <0.00%> (ø)` | | | [x/fbridge/keeper/keeper.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1347?src=pr&el=tree&filepath=x%2Ffbridge%2Fkeeper%2Fkeeper.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mYnJpZGdlL2tlZXBlci9rZWVwZXIuZ28=) | `50.00% <50.00%> (ø)` | | | [x/fbridge/keeper/transfer.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1347?src=pr&el=tree&filepath=x%2Ffbridge%2Fkeeper%2Ftransfer.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mYnJpZGdlL2tlZXBlci90cmFuc2Zlci5nbw==) | `72.09% <72.09%> (ø)` | | | [x/fbridge/keeper/msg\_server.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1347?src=pr&el=tree&filepath=x%2Ffbridge%2Fkeeper%2Fmsg_server.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mYnJpZGdlL2tlZXBlci9tc2dfc2VydmVyLmdv) | `0.00% <0.00%> (ø)` | |
hyunsooda commented 2 months ago

How about to start the sequence number from 1?

tkxkd0159 commented 2 months ago

How about to start the sequence number from 1?

it's already be started from 1.

hyunsooda commented 2 months ago

@tkxkd0159 You should add the sequence to block number mapping, which is not included here. Please add it ASAP.

hyunsooda commented 2 months ago

Could you also teach me how to execute predefined queries such as nextseq? While the command simd query bridge nextseq-send functions correctly, the corresponding curl command curl -X GET "http://localhost:1317/cosmos/fbridge/nextseq_send" -H "Accept: application/json" does not work.