search

Finschia / finschia-sdk

A framework for building blockchains based Finschia Mainnet that is forked from cosmos-sdk
Apache License 2.0
62 stars 29 forks source link

feat(x/fbridge): set target denom as module parameters (backport #1366) #1368

Closed mergify[bot] closed 2 months ago

mergify[bot] commented 2 months ago

Description

closes: #XXXX

Motivation and context

How has this been tested?

Screenshots (if appropriate):

Checklist:

codecov[bot] commented 2 months ago

Codecov Report

Attention: Patch coverage is 28.00000% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 68.87%. Comparing base (74e5686) to head (c839b92).

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1368/graphs/tree.svg?width=650&height=150&src=pr&token=m16qfzIPO7&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1368?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) ```diff @@ Coverage Diff @@ ## release/v0.49.x #1368 +/- ## =================================================== - Coverage 68.90% 68.87% -0.03% =================================================== Files 675 675 Lines 69167 69199 +32 =================================================== + Hits 47657 47659 +2 - Misses 19231 19260 +29 - Partials 2279 2280 +1 ``` | [Files](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1368?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia) | Coverage Δ | | |---|---|---| | [simapp/app.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1368?src=pr&el=tree&filepath=simapp%2Fapp.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-c2ltYXBwL2FwcC5nbw==) | `82.28% <100.00%> (ø)` | | | [x/fbridge/keeper/keeper.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1368?src=pr&el=tree&filepath=x%2Ffbridge%2Fkeeper%2Fkeeper.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mYnJpZGdlL2tlZXBlci9rZWVwZXIuZ28=) | `72.04% <100.00%> (-0.30%)` | :arrow_down: | | [x/fbridge/keeper/params.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1368?src=pr&el=tree&filepath=x%2Ffbridge%2Fkeeper%2Fparams.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mYnJpZGdlL2tlZXBlci9wYXJhbXMuZ28=) | `82.35% <100.00%> (+5.42%)` | :arrow_up: | | [x/fbridge/keeper/transfer.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1368?src=pr&el=tree&filepath=x%2Ffbridge%2Fkeeper%2Ftransfer.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mYnJpZGdlL2tlZXBlci90cmFuc2Zlci5nbw==) | `71.87% <100.00%> (ø)` | | | [x/fbridge/types/codec.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1368?src=pr&el=tree&filepath=x%2Ffbridge%2Ftypes%2Fcodec.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mYnJpZGdlL3R5cGVzL2NvZGVjLmdv) | `56.41% <50.00%> (-0.35%)` | :arrow_down: | | [x/fbridge/types/genesis.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1368?src=pr&el=tree&filepath=x%2Ffbridge%2Ftypes%2Fgenesis.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mYnJpZGdlL3R5cGVzL2dlbmVzaXMuZ28=) | `0.00% <0.00%> (ø)` | | | [x/fbridge/keeper/genesis.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1368?src=pr&el=tree&filepath=x%2Ffbridge%2Fkeeper%2Fgenesis.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mYnJpZGdlL2tlZXBlci9nZW5lc2lzLmdv) | `8.82% <0.00%> (-1.79%)` | :arrow_down: | | [x/fbridge/types/msgs.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1368?src=pr&el=tree&filepath=x%2Ffbridge%2Ftypes%2Fmsgs.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mYnJpZGdlL3R5cGVzL21zZ3MuZ28=) | `0.00% <0.00%> (ø)` | | | [x/fbridge/types/params.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1368?src=pr&el=tree&filepath=x%2Ffbridge%2Ftypes%2Fparams.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mYnJpZGdlL3R5cGVzL3BhcmFtcy5nbw==) | `35.55% <0.00%> (-3.47%)` | :arrow_down: | | [x/fbridge/keeper/msg\_server.go](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1368?src=pr&el=tree&filepath=x%2Ffbridge%2Fkeeper%2Fmsg_server.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia#diff-eC9mYnJpZGdlL2tlZXBlci9tc2dfc2VydmVyLmdv) | `0.00% <0.00%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/Finschia/finschia-sdk/pull/1368/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Finschia)